Commitd047419

authored

fix: inserting non-finite floats with insert_rows() (#728)

1 parentddd9ce7 commitd047419Copy full SHA for d047419

File tree

+22

-1

lines changed

+22

-1

lines changed

Lines changed: 7 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -17,6 +17,7 @@`
`17`	`17`	`importbase64`
`18`	`18`	`importdatetime`
`19`	`19`	`importdecimal`
	`20`	`+importmath`
`20`	`21`	`importre`
`21`	`22`
`22`	`23`	`fromgoogle.cloud._helpersimportUTC`
`@@ -305,7 +306,12 @@ def _int_to_json(value):`
`305`	`306`
`306`	`307`	`def_float_to_json(value):`
`307`	`308`	`"""Coerce 'value' to an JSON-compatible representation."""`
`308`		`-returnvalueifvalueisNoneelsefloat(value)`
	`309`	`+ifvalueisNone:`
	`310`	`+returnNone`
	`311`	`+elifmath.isnan(value)ormath.isinf(value):`
	`312`	`+returnstr(value)`
	`313`	`+else:`
	`314`	`+returnfloat(value)`
`309`	`315`
`310`	`316`
`311`	`317`	`def_decimal_to_json(value):`

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -656,9 +656,24 @@ def _call_fut(self, value):`
`656`	`656`
`657`	`657`	`return_float_to_json(value)`
`658`	`658`
	`659`	`+deftest_w_none(self):`
	`660`	`+self.assertEqual(self._call_fut(None),None)`
	`661`	`+`
`659`	`662`	`deftest_w_float(self):`
`660`	`663`	`self.assertEqual(self._call_fut(1.23),1.23)`
`661`	`664`
	`665`	`+deftest_w_nan(self):`
	`666`	`+result=self._call_fut(float("nan"))`
	`667`	`+self.assertEqual(result.lower(),"nan")`
	`668`	`+`
	`669`	`+deftest_w_infinity(self):`
	`670`	`+result=self._call_fut(float("inf"))`
	`671`	`+self.assertEqual(result.lower(),"inf")`
	`672`	`+`
	`673`	`+deftest_w_negative_infinity(self):`
	`674`	`+result=self._call_fut(float("-inf"))`
	`675`	`+self.assertEqual(result.lower(),"-inf")`
	`676`	`+`
`662`	`677`
`663`	`678`	`classTest_decimal_to_json(unittest.TestCase):`
`664`	`679`	`def_call_fut(self,value):`

Comments

(0)