Commit6cc6876

authored

feat: add with_name() to ScalarQueryParameterType (#644)

* feat: add with_name() to ScalarQueryParameterType* Clarify unsetting a name, add extra test

1 parentbe3c49a commit6cc6876Copy full SHA for 6cc6876

File tree

+35

-0

lines changed

+35

-0

lines changed

Lines changed: 15 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -16,6 +16,7 @@`
`16`	`16`
`17`	`17`	`fromcollectionsimportOrderedDict`
`18`	`18`	`importcopy`
	`19`	`+fromtypingimportUnion`
`19`	`20`
`20`	`21`	`fromgoogle.cloud.bigquery.tableimport_parse_schema_resource`
`21`	`22`	`fromgoogle.cloud.bigquery._helpersimport_rows_from_json`
`@@ -119,6 +120,20 @@ def to_api_repr(self):`
`119`	`120`	`# attributes in the API representation when needed. Here we omit them.`
`120`	`121`	`return {"type":self._type}`
`121`	`122`
	`123`	`+defwith_name(self,new_name:Union[str,None]):`
	`124`	+"""Return a copy of the instance with ``name`` set to ``new_name``.
	`125`	`+`
	`126`	`+ Args:`
	`127`	`+ name (Union[str, None]):`
	`128`	+ The new name of the query parameter type. If ``None``, the existing
	`129`	`+ name is cleared.`
	`130`	`+`
	`131`	`+ Returns:`
	`132`	`+ google.cloud.bigquery.query.ScalarQueryParameterType:`
	`133`	`+ A new instance with updated name.`
	`134`	`+ """`
	`135`	`+returntype(self)(self._type,name=new_name,description=self.description)`
	`136`	`+`
`122`	`137`	`def__repr__(self):`
`123`	`138`	`name=f", name={self.name!r}"ifself.nameisnotNoneelse""`
`124`	`139`	`description= (`

Lines changed: 20 additions & 0 deletions

Original file line number	Diff line number	Diff line change
`@@ -98,6 +98,26 @@ def test_repr_all_optional_attrs(self):`
`98`	`98`	`"ScalarQueryParameterType('BYTES', name='foo', description='this is foo')",`
`99`	`99`	`)`
`100`	`100`
	`101`	`+deftest_with_name_returns_copy_w_changed_name(self):`
	`102`	`+param_type=self._make_one("BOOLEAN",name=None,description="Some checkbox.")`
	`103`	`+modified_type=param_type.with_name("allow_emails")`
	`104`	`+`
	`105`	`+self.assertIsNot(modified_type,param_type)# Result is a copy.`
	`106`	`+self.assertEqual(modified_type.name,"allow_emails")`
	`107`	`+`
	`108`	`+# The rest of the The rest of the fields should have been preserved.`
	`109`	`+self.assertEqual(modified_type._type,param_type._type)`
	`110`	`+self.assertEqual(modified_type.description,param_type.description)`
	`111`	`+`
	`112`	`+deftest_with_name_clearing_the_value(self):`
	`113`	`+param_type=self._make_one(`
	`114`	`+"BOOLEAN",name="allow_emails",description="Some checkbox."`
	`115`	`+ )`
	`116`	`+modified_type=param_type.with_name(None)`
	`117`	`+`
	`118`	`+self.assertIsNone(modified_type.name)`
	`119`	`+self.assertEqual(param_type.name,"allow_emails")# original unchanged`
	`120`	`+`
`101`	`121`
`102`	`122`	`classTest_ArrayQueryParameterType(unittest.TestCase):`
`103`	`123`	`@staticmethod`

Comments

(0)