NotificationsYou must be signed in to change notification settings
Fork321
Star786

Commit5ed9cce

authored

feat: Add compression option ZSTD. (#1890)

* Add ZSTD to compression types* feat: adds tests re Compression types* revise datatype from Enum to object* adds license text and docstring* change object back to enum datatype* updates compression object comparison* updates Compression class* jsonify and sort the input and output for testing* Update tests/unit/job/test_extract.py* moved json import statement* removed enums test and file---------Co-authored-by: Ethan Steinberg <ethan.steinberg@gmail.com>Co-authored-by: Tim Sweña (Swast) <swast@google.com>

1 parent19394ab commit5ed9cceCopy full SHA for 5ed9cce

File tree

2 files changed

+13

-4

lines changed

google/cloud/bigquery
- enums.py
tests/unit/job
- test_extract.py

2 files changed

+13

-4

lines changed

`‎google/cloud/bigquery/enums.py‎`

Lines changed: 4 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -22,7 +22,7 @@ class AutoRowIDs(enum.Enum):`
`22`	`22`	`GENERATE_UUID=enum.auto()`
`23`	`23`
`24`	`24`
`25`		`-classCompression(object):`
	`25`	`+classCompression(str,enum.Enum):`
`26`	`26`	`"""The compression type to use for exported files. The default value is`
`27`	`27`	:attr:`NONE`.
`28`	`28`
`@@ -39,6 +39,9 @@ class Compression(object):`
`39`	`39`	`SNAPPY="SNAPPY"`
`40`	`40`	`"""Specifies SNAPPY format."""`
`41`	`41`
	`42`	`+ZSTD="ZSTD"`
	`43`	`+"""Specifies ZSTD format."""`
	`44`	`+`
`42`	`45`	`NONE="NONE"`
`43`	`46`	`"""Specifies no compression."""`
`44`	`47`

`‎tests/unit/job/test_extract.py‎`

Lines changed: 9 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -12,6 +12,7 @@`
`12`	`12`	`# See the License for the specific language governing permissions and`
`13`	`13`	`# limitations under the License.`
`14`	`14`
	`15`	`+importjson`
`15`	`16`	`fromunittestimportmock`
`16`	`17`
`17`	`18`	`from ..helpersimportmake_connection`
`@@ -45,9 +46,8 @@ def test_to_api_repr(self):`
`45`	`46`	`config.print_header=False`
`46`	`47`	`config._properties["extract"]["someNewField"]="some-value"`
`47`	`48`	`config.use_avro_logical_types=True`
`48`		`-resource=config.to_api_repr()`
`49`		`-self.assertEqual(`
`50`		`-resource,`
	`49`	`+resource=json.dumps(config.to_api_repr(),sort_keys=True)`
	`50`	`+expected=json.dumps(`
`51`	`51`	`{`
`52`	`52`	`"extract": {`
`53`	`53`	`"compression":"SNAPPY",`
`@@ -58,6 +58,12 @@ def test_to_api_repr(self):`
`58`	`58`	`"useAvroLogicalTypes":True,`
`59`	`59`	`}`
`60`	`60`	`},`
	`61`	`+sort_keys=True,`
	`62`	`+ )`
	`63`	`+`
	`64`	`+self.assertEqual(`
	`65`	`+resource,`
	`66`	`+expected,`
`61`	`67`	`)`
`62`	`68`
`63`	`69`	`deftest_from_api_repr(self):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit5ed9cce

File tree

2 files changed

2 files changed

`‎google/cloud/bigquery/enums.py‎`

`‎tests/unit/job/test_extract.py‎`

0 commit comments