NotificationsYou must be signed in to change notification settings
Fork321
Star786

Commit54c8d07

authored

fix: avoid blocking in download thread when using BQ Storage API (#2034)

This prevents a deadlock between the main thead and download threadswhen the threadpool is shutdown prematurely.Co-authored-by: Chalmer Lowe <chalmerlowe@google.com>Co-authored-by: Tim Sweña (Swast) <swast@google.com>

1 parent3a48948 commit54c8d07Copy full SHA for 54c8d07

File tree

1 file changed

-3

lines changed

google/cloud/bigquery
- _pandas_helpers.py

1 file changed

-3

lines changed

`‎google/cloud/bigquery/_pandas_helpers.py‎`

Lines changed: 8 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -796,10 +796,15 @@ def _download_table_bqstorage_stream(`
`796`	`796`	`rowstream=reader.rows(session)`
`797`	`797`
`798`	`798`	`forpageinrowstream.pages:`
`799`		`-ifdownload_state.done:`
`800`		`-return`
`801`	`799`	`item=page_to_item(page)`
`802`		`-worker_queue.put(item)`
	`800`	`+whileTrue:`
	`801`	`+ifdownload_state.done:`
	`802`	`+return`
	`803`	`+try:`
	`804`	`+worker_queue.put(item,timeout=_PROGRESS_INTERVAL)`
	`805`	`+break`
	`806`	`+exceptqueue.Full:# pragma: NO COVER`
	`807`	`+continue`
`803`	`808`
`804`	`809`
`805`	`810`	`def_nowait(futures):`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit54c8d07

File tree

1 file changed

1 file changed

`‎google/cloud/bigquery/_pandas_helpers.py‎`

0 commit comments