Commit20f473b

authored

fix: make TimePartitioning repr evaluable (#110)

Fixes#109 🦕

1 parent5ea1ece commit20f473bCopy full SHA for 20f473b

File tree

+16

-3

lines changed

+16

-3

lines changed

Lines changed: 14 additions & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -2114,7 +2114,20 @@ def to_api_repr(self):`
`2114`	`2114`	`returnself._properties`
`2115`	`2115`
`2116`	`2116`	`def_key(self):`
`2117`		`-returntuple(sorted(self._properties.items()))`
	`2117`	`+# because we are only "renaming" top level keys shallow copy is sufficient here.`
	`2118`	`+properties=self._properties.copy()`
	`2119`	`+# calling repr for non built-in type objects.`
	`2120`	`+properties["type_"]=repr(properties.pop("type"))`
	`2121`	`+if"field"inproperties:`
	`2122`	`+# calling repr for non built-in type objects.`
	`2123`	`+properties["field"]=repr(properties["field"])`
	`2124`	`+if"requirePartitionFilter"inproperties:`
	`2125`	`+properties["require_partition_filter"]=properties.pop(`
	`2126`	`+"requirePartitionFilter"`
	`2127`	`+ )`
	`2128`	`+if"expirationMs"inproperties:`
	`2129`	`+properties["expiration_ms"]=properties.pop("expirationMs")`
	`2130`	`+returntuple(sorted(properties.items()))`
`2118`	`2131`
`2119`	`2132`	`def__eq__(self,other):`
`2120`	`2133`	`ifnotisinstance(other,TimePartitioning):`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -3711,7 +3711,7 @@ def test___hash__not_equals(self):`
`3711`	`3711`
`3712`	`3712`	`deftest___repr___minimal(self):`
`3713`	`3713`	`time_partitioning=self._make_one()`
`3714`		`-expected="TimePartitioning(type=DAY)"`
	`3714`	`+expected="TimePartitioning(type_='DAY')"`
`3715`	`3715`	`self.assertEqual(repr(time_partitioning),expected)`
`3716`	`3716`
`3717`	`3717`	`deftest___repr___explicit(self):`
`@@ -3720,7 +3720,7 @@ def test___repr___explicit(self):`
`3720`	`3720`	`time_partitioning=self._make_one(`
`3721`	`3721`	`type_=TimePartitioningType.DAY,field="name",expiration_ms=10000`
`3722`	`3722`	`)`
`3723`		`-expected="TimePartitioning(""expirationMs=10000,""field=name,""type=DAY)"`
	`3723`	`+expected="TimePartitioning(expiration_ms=10000,field='name',type_='DAY')"`
`3724`	`3724`	`self.assertEqual(repr(time_partitioning),expected)`
`3725`	`3725`
`3726`	`3726`	`deftest_set_expiration_w_none(self):`

Comments

(0)