NotificationsYou must be signed in to change notification settings
Fork95
Star144

feat: support for async bidi streaming apis#836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

vchudnov-g merged 31 commits intogoogleapis:mainfromchandra-siri:feat/834-bidi-async-support

Oct 14, 2025

Merged

feat: support for async bidi streaming apis#836

vchudnov-g merged 31 commits intogoogleapis:mainfromchandra-siri:feat/834-bidi-async-support

Oct 14, 2025

+676 −63

Conversation

Copy link

Contributor

chandra-siri commentedAug 14, 2025•
edited
Loading

feat: support for async bidi streaming apis

Further details can be foundhere

Fixes#834

feat: support for async bidi streaming apis

d751f63

product-auto-labelbot added the size: lPull request size is large. label

Aug 14, 2025

chandra-siri added11 commits

August 14, 2025 06:57

fix linting

fdcd903

Add bidiBase, refactor bidiRpc and add AsyncBidi

5835178

remove changes from noxfile

df8fba5

use queue.get() instead of queue.get_nowait()

19cf273

use asyncio.wait_for instead of asyncio.timeout

5b6d287

python versions <= 3.10 dont support `async with asyncio.timeout`

aiter() and anext() are not defined in python<=3.9

2599f96

provide support for the same.

remove support for python 3.7 and below

9c1a621

fix mypy errors

cc19089

fix typo, version -> version_info

a86a9b1

AsyncMock not present in python3.7

5464dc5

update doc strings

e96a409

chandra-siri marked this pull request as ready for review

August 30, 2025 17:13

chandra-siri requested review froma team ascode owners

August 30, 2025 17:13

blunderbuss-gcfbot assignedvchudnov-g

Aug 30, 2025

chandra-siri added3 commits

September 1, 2025 11:39

use pytest.approx to round of floating point errors.

52686b8

add tolerance

d01421b

add test_open_error_call_error unit test

98eae06

ohmayr reviewed

Sep 4, 2025

View reviewed changes

google/api_core/bidi_async.py OutdatedShow resolvedHide resolved

google/api_core/bidi.pyShow resolvedHide resolved

google/api_core/bidi_async.py OutdatedShow resolvedHide resolved

google/api_core/bidi_base.py OutdatedShow resolvedHide resolved

google/api_core/bidi_async.pyShow resolvedHide resolved

chandra-siri added3 commits

September 8, 2025 18:17

Merge branch 'main' ofhttps://github.com/googleapis/python-api-core…

af2121c

…into feat/834-bidi-async-support

minor changes based on PR comments

5a7550f

formatting fixes

c486c49

chandra-siri requested a review fromohmayr

September 8, 2025 19:25

remove changes from test_method.py

14342b1

chandra-siri added a commit to chandra-siri/python-storage that referenced this pull request

Sep 17, 2025

Add async bidiRpc files in python-storage

32168a6

these files will be removed oncegoogleapis/python-api-core#836gets submitted

chandra-siri mentioned this pull request

Sep 17, 2025

feat: Add async bidiRpc files in python-storagegoogleapis/python-storage#1545

Merged

fix typos in doc string and error msg

6fabb1f

chandra-siri added a commit to googleapis/python-storage that referenced this pull request

Sep 18, 2025

feat: Add async bidiRpc files in python-storage (#1545)

8b988ad

* Add async bidiRpc files in python-storagethese files will be removed oncegoogleapis/python-api-core#836gets submitted* fix import path for bidi_base

chandra-siri added2 commits

October 1, 2025 13:45

address review comments. mostly fix doc-strings

b963922

Merge branch 'main' ofhttps://github.com/googleapis/python-api-core…

470aeb4

…into feat/834-bidi-async-support

Copy link

ContributorAuthor

chandra-siri commentedOct 1, 2025

Looks good. I have some small comments, and a bunch of nits. I'll TAL at the test next week.

@vchudnov-g Addressed your comments. PTAL

remove unused variable to fix lint

7475d99

chandra-siri requested review fromohmayr andvchudnov-g

October 1, 2025 13:54

vchudnov-g reviewed

Oct 4, 2025

View reviewed changes

Copy link

Contributor

vchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good. We're almost there. Just some minor comments, and I want to ping@daniel-sanche again in case he has any comments.

google/api_core/bidi.py OutdatedShow resolvedHide resolved

google/api_core/bidi_async.py


		request_generator.call = call

		if hasattr(call, "_wrapped"): # pragma: NO COVER

Copy link

Contributor

vchudnov-gOct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It doesn't have an issue. You could create one, but at least copy the text:# TODO: api_core should expose the future interface for wrapped callables as well.

google/api_core/bidi_async.py


		request_generator.call = call

		if hasattr(call, "_wrapped"): # pragma: NO COVER

Copy link

Contributor

vchudnov-gOct 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

No issue number (you could create one), but let's at least include the text: # TODO: api_core should expose the future interface for wrapped callables as well.

google/api_core/bidi_base.pyShow resolvedHide resolved

tests/asyncio/test_bidi_async.pyShow resolvedHide resolved

tests/asyncio/test_bidi_async.py OutdatedShow resolvedHide resolved

daniel-sanche reviewed

Oct 6, 2025

View reviewed changes

Copy link

Contributor

daniel-sanche left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I left a few small comments, but nothing that needs to be blocking

Type checking would improve this a lot though, to help us be sure there are no gaps in the shared sync/async logic

google/api_core/bidi_base.py OutdatedShow resolvedHide resolved

google/api_core/bidi_base.pyShow resolvedHide resolved

google/api_core/bidi_base.py OutdatedShow resolvedHide resolved

google/api_core/bidi_base.pyShow resolvedHide resolved

daniel-sanche reviewed

Oct 6, 2025

View reviewed changes

google/api_core/bidi_async.pyShow resolvedHide resolved

fix & imporove docstrings & comments. Reduce test timeout duration

8bf8396

Copy link

ContributorAuthor

chandra-siri commentedOct 8, 2025

I left a few small comments, but nothing that needs to be blocking
Type checking would improve this a lot though, to help us be sure there are no gaps in the shared sync/async logic

Hi@daniel-sanche , I've addressed your comments, leftone open. Feel free to resolve it sounds good to you.