Movatterモバイル変換

Skip to content

googleapis/python-api-corePublic

NotificationsYou must be signed in to change notification settings
Fork90
Star131

fix: add stop() call to BackgroundConsumer failures due to exceptions#821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Open

abbrowne126 wants to merge5 commits intomain

base:main

Choose a base branch

fromfix-background-consumer-error-closures

Open

fix: add stop() call to BackgroundConsumer failures due to exceptions#821

abbrowne126 wants to merge5 commits intomainfromfix-background-consumer-error-closures

Conversation

abbrowne126

Copy link

abbrowne126 commentedMay 23, 2025

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes#820

@abbrowne126

fix: add stop() call to BackgroundConsumer failures due to exceptions

bf74b4a

@abbrowne126

abbrowne126 requested review froma team ascode owners

May 23, 2025 16:22

@blunderbuss-gcf

blunderbuss-gcfbot assignedparthea

@product-auto-label

product-auto-labelbot added the size: sPull request size is small. label

@gcf-owl-bot

🦉 Updates from OwlBot post-processor

8a4d671

Seehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

@abbrowne126

abbrowne126 marked this pull request as draft

May 23, 2025 16:24

abbrowne126 added3 commits

May 23, 2025 12:39

@abbrowne126

move stop call to within the exception clauses

c18475c

@abbrowne126

Merge branch 'fix-background-consumer-error-closures' ofhttps://gith…

c9b41e8

…ub.com/googleapis/python-api-core into fix-background-consumer-error-closures

@abbrowne126

Update test_bidi.py

8a9a7d8

@abbrowne126

abbrowne126 marked this pull request as ready for review

May 23, 2025 16:45

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Pull request size is small.

2 participants

@abbrowne126

@parthea

[8]ページ先頭

©2009-2025 Movatter.jp