Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

test: fix BackgroundConsumer error log#814

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
daniel-sanche merged 6 commits intomainfromb_788
Apr 10, 2025
Merged

test: fix BackgroundConsumer error log#814

daniel-sanche merged 6 commits intomainfromb_788
Apr 10, 2025

Conversation

daniel-sanche
Copy link
Contributor

We#770 that clears some variables that were causing a memory leak in the bidirectional streaming classes. This change lead to a potential null pointer exception during the shut-down process when the BackgroundConsumer tries to access the removed callback.

The issue would only come up when the background thread failed to finalize within 1 second, and the error would be swallowed internally. But it would result in an error log that should be avoided

This PR does a None check to avoid emitting the error log

Fixes#788

@daniel-sanchedaniel-sanche requested review froma team ascode ownersApril 4, 2025 22:20
@product-auto-labelproduct-auto-labelbot added the size: sPull request size is small. labelApr 4, 2025
@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. and removed size: sPull request size is small. labelsApr 4, 2025
@product-auto-labelproduct-auto-labelbot added size: lPull request size is large. and removed size: mPull request size is medium. labelsApr 5, 2025
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. and removed size: lPull request size is large. labelsApr 5, 2025
@daniel-sanchedaniel-sanche merged commit66d84a3 intomainApr 10, 2025
47 checks passed
@daniel-sanchedaniel-sanche deleted the b_788 branchApril 10, 2025 23:31
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vchudnov-gvchudnov-gvchudnov-g approved these changes

Assignees

@vchudnov-gvchudnov-g

Labels
size: sPull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BackgroundConsumer destruction issues
2 participants
@daniel-sanche@vchudnov-g

[8]ページ先頭

©2009-2025 Movatter.jp