Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: support dynamic retry backoff values#793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 12 commits intomainfrompostpone_sleep_generation
Mar 19, 2025

Conversation

daniel-sanche
Copy link
Contributor

This PR moves backoff generation until after an rpc is complete and on_error callbacks have been called. This gives the client a chance to change what backoff value is used based on the error details.

This feature is required for Bigtable, where the backend can send retry_info packets to inform the client on how long to wait before a retry

Fixes#792

Copy link
Collaborator

@partheaparthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Local testing looks good. Test results ingoogleapis/gapic-generator-python#2359 look good. I'm also waiting for test results in cl/736133031. Once the tests in cl/736133031 pass and we are confident that there won't be an infinite loop ( due to use ofwhile True without another exit condition), we can move forward with this PR.

@partheaparthea marked this pull request as draftMarch 17, 2025 13:33
@parthea
Copy link
Collaborator

I'm going to move this to draft until a regression test is added. Please mark it as ready to review when this PR is ready.

@daniel-sanchedaniel-sanche marked this pull request as ready for reviewMarch 17, 2025 23:25
@daniel-sanche
Copy link
ContributorAuthor

The tests have been added, so this is ready to review again

@partheaparthea merged commit70697a3 intomainMar 19, 2025
46 checks passed
@partheaparthea deleted the postpone_sleep_generation branchMarch 19, 2025 15:09
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@partheapartheaparthea approved these changes

@vchudnov-gvchudnov-gAwaiting requested review from vchudnov-g

@ohmayrohmayrAwaiting requested review from ohmayr

Labels
size: mPull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Retry should generate sleep time after attempt
4 participants
@daniel-sanche@parthea@vchudnov-g@ohmayr
[8]ページ先頭
©2009-2025 Movatter.jp