Jan 22, 2025 · Dec 16, 2024 · Dec 16, 2024 · Jan 22, 2025 · Dec 16, 2024 · Jan 22, 2025
diff --git a/google/api_core/bidi.py b/google/api_core/bidi.py
        self._request_queue.put(None)
        self.call.cancel()
        self._request_generator = None
        self._initial_request = None
        self._callbacks = []
        # Don't set self.call to None. Keep it around so that send/recv can
        # raise the error.

                    _LOGGER.warning("Background thread did not exit.")

            self._thread = None
            self._on_response = None

    @property
    def is_active(self):
diff --git a/tests/unit/test_bidi.py b/tests/unit/test_bidi.py
        # ensure the request queue was signaled to stop.
        assert bidi_rpc.pending_requests == 1
        assert bidi_rpc._request_queue.get() is None
        # ensure request and callbacks are cleaned up
        assert bidi_rpc._initial_request is None
        assert not bidi_rpc._callbacks

    def test_close_no_rpc(self):
        bidi_rpc = bidi.BidiRpc(None)
        assert bidi_rpc.pending_requests == 1
        assert bidi_rpc._request_queue.get() is None
        assert bidi_rpc._finalized
        assert bidi_rpc._initial_request is None
        assert not bidi_rpc._callbacks

    def test_reopen_failure_on_rpc_restart(self):
        error1 = ValueError("1")
        consumer.stop()

        assert consumer.is_active is False
        assert consumer._on_response is None

    def test_wake_on_error(self):
        should_continue = threading.Event()

        consumer.stop()
        assert consumer.is_active is False
        assert consumer._on_response is None

        # calling stop twice should not result in an error.
        consumer.stop()
Original file line number	Diff line number	Diff line change
Expand Up		@@ -306,6 +306,8 @@ def close(self):
		self._request_queue.put(None)
		self.call.cancel()
		self._request_generator = None
		self._initial_request = None
		self._callbacks = []
		# Don't set self.call to None. Keep it around so that send/recv can
		# raise the error.

Expand DownExpand Up		@@ -717,6 +719,7 @@ def stop(self):
		_LOGGER.warning("Background thread did not exit.")

		self._thread = None
		self._on_response = None
Copy link ContributorAuthor daniel-sancheDec 16, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. This assumes you can't restart an instance after it has been stopped. The test cases and docstrings point to that being the case, but it's not completely clear Copy link Collaborator partheaJan 22, 2025 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. I think this is a reasonable assumption given that resources should be cleaned up when`close` is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.

		@property
		def is_active(self):
Expand Down
Original file line number	Diff line number	Diff line change
Expand Up		@@ -296,6 +296,9 @@ def test_close(self):
		# ensure the request queue was signaled to stop.
		assert bidi_rpc.pending_requests == 1
		assert bidi_rpc._request_queue.get() is None
		# ensure request and callbacks are cleaned up
		assert bidi_rpc._initial_request is None
		assert not bidi_rpc._callbacks

		def test_close_no_rpc(self):
		bidi_rpc = bidi.BidiRpc(None)
Expand DownExpand Up		@@ -623,6 +626,8 @@ def cancel_side_effect():
		assert bidi_rpc.pending_requests == 1
		assert bidi_rpc._request_queue.get() is None
		assert bidi_rpc._finalized
		assert bidi_rpc._initial_request is None
		assert not bidi_rpc._callbacks

		def test_reopen_failure_on_rpc_restart(self):
		error1 = ValueError("1")
Expand DownExpand Up		@@ -777,6 +782,7 @@ def on_response(response):
		consumer.stop()

		assert consumer.is_active is False
		assert consumer._on_response is None

		def test_wake_on_error(self):
		should_continue = threading.Event()
Expand DownExpand Up		@@ -884,6 +890,7 @@ def close_side_effect():

		consumer.stop()
		assert consumer.is_active is False
		assert consumer._on_response is None

		# calling stop twice should not result in an error.
		consumer.stop()