Dec 6, 2024 · Dec 5, 2024 · Dec 6, 2024 · Dec 6, 2024 · Dec 6, 2024
diff --git a/google/api_core/client_logging.py b/google/api_core/client_logging.py
    "rpcName",
    "serviceName",
    "credentialsType",
    "credentialInfo",
    "credentialsInfo",
    "universeDomain",
    "request",
    "response",
    "metadata",
    "retryAttempt",
    "httpResponse",
 ]  # Additional fields to be Logged.
Original file line number	Diff line number	Diff line change
Expand Up		@@ -15,12 +15,13 @@
		"rpcName",
		"serviceName",
		"credentialsType",
		"credentialInfo",
		"credentialsInfo",
		"universeDomain",
		"request",
		"response",
		"metadata",
Copy link Contributor vchudnov-gDec 6, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Per the parent design doc, we should still have`rpcName`, right? (We're using it in the pending PR in the generator) Copy link ContributorAuthor ohmayrDec 6, 2024• edited Loading Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Yes we should. I see it here it in the list. Let me know if you see otherwise. Copy link Contributor vchudnov-gDec 6, 2024 Choose a reason for hiding this comment The reason will be displayed to describe this comment to others.Learn more. Oh, my bad. Don't know why I didn't see it before.
		"retryAttempt",
		"httpResponse",
		] # Additional fields to be Logged.


Expand Down