Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add automatic logging config to support debug logging#754

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 18 commits intomainfromdebug-logging
Dec 2, 2024

Conversation

ohmayr
Copy link
Contributor

@ohmayrohmayr commentedNov 4, 2024•
edited by parthea
Loading

Implement automatic logging config to allow users to enable debug logging via an environment variable.

Fixes b/381099872

@product-auto-labelproduct-auto-labelbot added the size: sPull request size is small. labelNov 4, 2024
@product-auto-labelproduct-auto-labelbot added size: mPull request size is medium. and removed size: sPull request size is small. labelsNov 11, 2024
@ohmayrohmayr changed the titlefeat: add base logger to enable debug loggingfeat: add automatic logging config to support debug loggingNov 25, 2024
@ohmayrohmayr marked this pull request as ready for reviewNovember 26, 2024 18:48
@ohmayrohmayr requested review froma team ascode ownersNovember 26, 2024 18:48
@product-auto-labelproduct-auto-labelbot added size: lPull request size is large. and removed size: mPull request size is medium. labelsNov 27, 2024
# Fields to be included in the StructuredLogFormatter.
#
# TODO(https://github.com/googleapis/python-api-core/issues/761): Update this list to support additional logging fields.
_recognized_logging_fields = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

One thing to note is that users will need to updategoogle-api-core to get any additional logging fields in the future.

Copy link
ContributorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This is true. Any fields that we add in the future will require users to updategoogle-api-core.

@partheaparthea merged commitd18d9b5 intomainDec 2, 2024
44 checks passed
@partheaparthea deleted the debug-logging branchDecember 2, 2024 11:12
@release-pleaserelease-pleasebot mentioned this pull requestDec 2, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@partheapartheaparthea approved these changes

@vchudnov-gvchudnov-gvchudnov-g approved these changes

Assignees

@partheaparthea

Labels
size: lPull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@ohmayr@parthea@vchudnov-g
[8]ページ先頭
©2009-2025 Movatter.jp