Movatterモバイル変換

Skip to content

googleapis/python-api-corePublic

NotificationsYou must be signed in to change notification settings
Fork90
Star131

chore: Revert "chore: move retry async check to wrap time"#743

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged

parthea merged 1 commit intomainfromrevert-668-move_async_warning

Oct 22, 2024

Merged

chore: Revert "chore: move retry async check to wrap time"#743

parthea merged 1 commit intomainfromrevert-668-move_async_warning

Oct 22, 2024

Conversation

parthea

Copy link

Collaborator

parthea commentedOct 22, 2024•
edited
Loading

Reverts#668

PR#668 causes tests to fail in thepython-bigquery repository. See build loghere from PRgoogleapis/python-bigquery#2045.

E               AssertionError: Calls not found.E               Expected: [call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),E                call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),E                call(method='GET', path='/projects/test-project-123/jobs/job-id', query_params={'projection': 'full', 'location': 'US'}, timeout=128)]E                 Actual: [call.__code__.co_flags.__and__(128),E                call.__code__.co_flags.__and__().__bool__(),E                call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),E                call(method='POST', path='/projects/test-project-123/jobs', data={'jobReference': {'jobId': 'job-id', 'projectId': 'test-project-123'}}, timeout=None),E                call.__code__.co_flags.__and__(128),E                call.__code__.co_flags.__and__().__bool__(),E                call(method='GET', path='/projects/test-project-123/jobs/job-id', query_params={'projection': 'full', 'location': 'US'}, timeout=128)]

@parthea

Revert "chore: move retry async check to wrap time (#668)"

c4880c3

This reverts commit3c69867.

@parthea

parthea requested review froma team ascode owners

October 22, 2024 17:22

@product-auto-label

product-auto-labelbot added the size: sPull request size is small. label

@blunderbuss-gcf

blunderbuss-gcfbot assignedvchudnov-g

tswast

tswast approved these changes

View reviewed changes

Copy link

Contributor

tswast left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

THanks!

@parthea

parthea merged commit7727405 intomain

43 checks passed

@parthea

parthea deleted the revert-668-move_async_warning branch

October 22, 2024 17:29

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Labels

Pull request size is small.

3 participants

@parthea

@tswast

@vchudnov-g

[8]ページ先頭

©2009-2025 Movatter.jp