Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: migrate to pyproject.toml#736

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 20 commits intogoogleapis:mainfromrinarakaki:pyproject
Oct 28, 2024
Merged

feat: migrate to pyproject.toml#736

parthea merged 20 commits intogoogleapis:mainfromrinarakaki:pyproject
Oct 28, 2024

Conversation

rinarakaki
Copy link
Contributor

@rinarakakirinarakaki commentedOct 15, 2024•
edited
Loading

Tracking issuegoogleapis/google-cloud-python#13171

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakakirinarakaki requested review froma team ascode ownersOctober 15, 2024 03:47
@product-auto-labelproduct-auto-labelbot added the size: mPull request size is medium. labelOct 15, 2024
@rinarakakirinarakaki changed the titlefeature: migrate to pyproject.tomlfeat: migrate to pyproject.tomlOct 16, 2024
@partheaparthea self-assigned thisOct 19, 2024
Copy link
Collaborator

@partheaparthea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

rinarakaki reacted with heart emoji
@partheaparthea added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelOct 19, 2024
@parthea
Copy link
Collaborator

Addingdo not merge until#729 is merged to avoid delaying the Python 3.13 release.

rinarakaki reacted with thumbs up emoji

@partheaparthea removed do not mergeIndicates a pull request not ready for merge, due to either quality or timing. process: review requested labelsOct 28, 2024
@partheaparthea merged commit159e9a4 intogoogleapis:mainOct 28, 2024
40 checks passed
@rinarakakirinarakaki deleted the pyproject branchOctober 28, 2024 16:15
@partheaparthea mentioned this pull requestOct 28, 2024
@rinarakaki
Copy link
ContributorAuthor

@parthea thanks for the review and the merge!

parthea reacted with thumbs up emoji

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@partheapartheaparthea approved these changes

@BenRKarlBenRKarlBenRKarl approved these changes

Assignees

@partheaparthea

Labels
size: mPull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4 participants
@rinarakaki@parthea@BenRKarl@vchudnov-g
[8]ページ先頭
©2009-2025 Movatter.jp