Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: add type hints to ClientOptions#735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 5 commits intogoogleapis:mainfromrinarakaki:typing
Oct 19, 2024
Merged

fix: add type hints to ClientOptions#735

parthea merged 5 commits intogoogleapis:mainfromrinarakaki:typing
Oct 19, 2024

Conversation

rinarakaki
Copy link
Contributor

@rinarakakirinarakaki commentedOct 11, 2024•
edited
Loading

Enablesgoogleapis/python-cloud-core#302

I checked:

  • pyright google/api_core/client_options.py

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@rinarakakirinarakaki requested review froma team ascode ownersOctober 11, 2024 09:09
@product-auto-labelproduct-auto-labelbot added the size: sPull request size is small. labelOct 11, 2024
@rinarakakirinarakaki changed the titleadd typingchore: add typingOct 11, 2024
@rinarakakirinarakaki changed the titlechore: add typingfix: add type hints to ClientOptionOct 12, 2024
@partheaparthea changed the titlefix: add type hints to ClientOptionfix: add type hints to ClientOptionsOct 19, 2024
@parthea
Copy link
Collaborator

Thanks@rinarakaki !

rinarakaki reacted with heart emoji

@partheaparthea merged commitb91ed19 intogoogleapis:mainOct 19, 2024
41 checks passed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@partheapartheaparthea approved these changes

Assignees

@partheaparthea

Labels
size: sPull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@rinarakaki@parthea
[8]ページ先頭
©2009-2025 Movatter.jp