NotificationsYou must be signed in to change notification settings
Fork90
Star131

fix: Switch to unittest.mock from mock#713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

parthea merged 7 commits intogoogleapis:mainfroms-t-e-v-e-n-k:switch-to-unittest-mock

Oct 9, 2024

Merged

fix: Switch to unittest.mock from mock#713

parthea merged 7 commits intogoogleapis:mainfroms-t-e-v-e-n-k:switch-to-unittest-mock

Oct 9, 2024

Conversation

Copy link

Contributor

s-t-e-v-e-n-k commentedOct 2, 2024•
edited by parthea
Loading

Now that the minimum supported version of Python is 3.7, we can stop using the external mock requirement, and import it from unittest. I have also attempted to keep imports ordered.

Fixes#377
Closes#676

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

s-t-e-v-e-n-k requested review froma team ascode owners

October 2, 2024 03:53

product-auto-labelbot added the size: mPull request size is medium. label

Oct 2, 2024

blunderbuss-gcfbot assignedohmayr

Oct 2, 2024

test: Switch to unittest.mock from mock

5f28e21

Now that the minimum supported version of Python is 3.7, we can stopusing the external mock requirement, and import it from unittest. I havealso attempted to keep imports ordered.Fixesgoogleapis#377

s-t-e-v-e-n-k force-pushed theswitch-to-unittest-mock branch from4db4bbf to5f28e21Compare

October 2, 2024 03:54

Copy link

Contributor

ohmayr commentedOct 2, 2024

@s-t-e-v-e-n-k, general comment:AsyncMock isn't part of the stdlib i.e.unitest.mock for Python 3.7. which we're using in our test code.

Copy link

ContributorAuthor

s-t-e-v-e-n-k commentedOct 3, 2024

Ahh, indeed, AsyncMock was added in 3.8. I'll modify this accordingly.

test: Fallback to external mock for AsyncMock

5583db4

AsyncMock is not included in unittest.mock under Python 3.7, so we mustfallback to the external mock requirement for that Python version. Onlyinstall it for that version.Keep this as a separate commit so it can be reverted when 3.7 isn'tsupported anymore.

s-t-e-v-e-n-k force-pushed theswitch-to-unittest-mock branch from98f3bec to5583db4Compare

October 3, 2024 11:44