Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add support for python 3.13#696

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 11 commits intomainfromadd-python-313
Oct 15, 2024
Merged

feat: add support for python 3.13#696

parthea merged 11 commits intomainfromadd-python-313
Oct 15, 2024

Conversation

parthea
Copy link
Collaborator

Fixes#695 🦕

@partheaparthea added the owlbot:runAdd this label to trigger the Owlbot post processor. labelSep 13, 2024
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelSep 13, 2024
@product-auto-labelproduct-auto-labelbot added the size: sPull request size is small. labelSep 13, 2024
@partheaparthea added the owlbot:runAdd this label to trigger the Owlbot post processor. labelSep 13, 2024
@gcf-owl-botgcf-owl-botbot removed the owlbot:runAdd this label to trigger the Owlbot post processor. labelSep 13, 2024
@parthea
Copy link
CollaboratorAuthor

parthea commentedSep 13, 2024•
edited
Loading

Blocked bygrpc/grpc#34922

@partheaparthea added the status: blockedResolving the issue is dependent on other work. labelSep 13, 2024
@partheaparthea self-assigned thisOct 9, 2024
@partheaparthea removed the status: blockedResolving the issue is dependent on other work. labelOct 9, 2024
@partheaparthea marked this pull request as ready for reviewOctober 9, 2024 17:12
@partheaparthea requested review froma team ascode ownersOctober 9, 2024 17:12
@partheaparthea removed their assignmentOct 9, 2024
@@ -95,7 +95,8 @@ def install_prerelease_dependencies(session, constraints_path):
prerel_deps = [
"google-auth",
"googleapis-common-protos",
"grpcio",
# Exclude grpcio!=1.67.0rc1 which does not support python 3.13
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Do we need to disable therc version? My assumption is that the latest stable version is installed by default.

Copy link
CollaboratorAuthor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Without this change, the pre-release test fails (Seehttps://github.com/googleapis/python-api-core/actions/runs/11259852849/job/31309789274)

Do we need to disable the rc version? My assumption is that the latest stable version is installed by default.

We don't get the stable version in theprerelease_deps nox session. We get the latest pre-release which ishttps://pypi.org/project/grpcio/1.67.0rc1/. We're not disabling allrc versions, just1.67.0rc1 which doesn't support python 3.13

Co-authored-by: ohmayr <omairnaveed@ymail.com>
@partheaparthea merged commit46b3d3a intomainOct 15, 2024
43 checks passed
@partheaparthea deleted the add-python-313 branchOctober 15, 2024 16:49
@release-pleaserelease-pleasebot mentioned this pull requestOct 9, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@ohmayrohmayrohmayr approved these changes

Assignees

@ohmayrohmayr

Labels
size: sPull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for Python 3.13
2 participants
@parthea@ohmayr
[8]ページ先頭
©2009-2025 Movatter.jp