Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

chore: move retry async check to wrap time#668

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 7 commits intomainfrommove_async_warning
Oct 21, 2024
Merged

Conversation

parthea
Copy link
Collaborator

@partheaparthea commentedJun 5, 2024•
edited
Loading

Opening a new PR to restore the features in#649 which were reverted in#667 due to tests failing in cl/640306895

cc@daniel-sanche

@product-auto-labelproduct-auto-labelbot added the size: sPull request size is small. labelJun 5, 2024
Copy link
Contributor

@daniel-sanchedaniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@partheaparthea self-assigned thisOct 9, 2024
@partheaparthea added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelOct 9, 2024
@partheaparthea changed the titleMove async warningchore: move retry async check to wrap timeOct 21, 2024
@partheaparthea added the status: investigatingThe issue is under investigation, which is determined to be non-trivial. labelOct 21, 2024
@parthea
Copy link
CollaboratorAuthor

parthea commentedOct 21, 2024•
edited
Loading

Waiting for test results in cl/688122871 Tests passed

@partheaparthea removed status: investigatingThe issue is under investigation, which is determined to be non-trivial. do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelsOct 21, 2024
@partheaparthea marked this pull request as ready for reviewOctober 21, 2024 14:45
@partheaparthea requested review froma team ascode ownersOctober 21, 2024 14:45
@partheaparthea merged commit3c69867 intomainOct 21, 2024
43 checks passed
@partheaparthea deleted the move_async_warning branchOctober 21, 2024 14:46
parthea added a commit that referenced this pull requestOct 22, 2024
parthea added a commit that referenced this pull requestOct 22, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@daniel-sanchedaniel-sanchedaniel-sanche approved these changes

Assignees

@partheaparthea

Labels
size: sPull request size is small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

2 participants
@parthea@daniel-sanche
[8]ページ先頭
©2009-2025 Movatter.jp