Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add caching to GapicCallable#666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 35 commits intomainfromoptimize_gapic_callable
Oct 21, 2024
Merged

Conversation

parthea
Copy link
Collaborator

@partheaparthea commentedJun 4, 2024•
edited
Loading

Opening a new PR to restore the features in#527 which were reverted in#665 due to#660

cc@daniel-sanche

BEGIN_COMMIT_OVERRIDE
chore: add caching to GapicCallable
END_COMMIT_OVERRIDE

daniel-sancheand others added28 commitsSeptember 6, 2023 22:59
@partheaparthea requested review froma team ascode ownersJune 4, 2024 14:29
@partheaparthea changed the titleOptimize gapic callablefeat: add caching to GapicCallableJun 4, 2024
@partheaparthea added the do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelJun 4, 2024
@partheaparthea marked this pull request as draftJune 4, 2024 14:32
Copy link
Contributor

@daniel-sanchedaniel-sanche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@daniel-sanche
Copy link
Contributor

@parthea Just changed the metadata type to a list, and added types to a docstring

@partheaparthea added the status: investigatingThe issue is under investigation, which is determined to be non-trivial. labelOct 21, 2024
@parthea
Copy link
CollaboratorAuthor

parthea commentedOct 21, 2024•
edited
Loading

Waiting for test results in cl/688135988 Tests passed

@partheaparthea removed status: investigatingThe issue is under investigation, which is determined to be non-trivial. do not mergeIndicates a pull request not ready for merge, due to either quality or timing. labelsOct 21, 2024
@partheaparthea marked this pull request as ready for reviewOctober 21, 2024 15:10
@partheaparthea merged commit1695119 intomainOct 21, 2024
43 checks passed
@partheaparthea deleted the optimize_gapic_callable branchOctober 21, 2024 15:11
parthea added a commit that referenced this pull requestOct 23, 2024
parthea added a commit that referenced this pull requestOct 23, 2024
@partheaparthea added the release-please:force-runTo run release-please labelOct 23, 2024
@release-pleaserelease-pleasebot removed the release-please:force-runTo run release-please labelOct 23, 2024
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@daniel-sanchedaniel-sanchedaniel-sanche approved these changes

Assignees

@partheaparthea

Labels
size: mPull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

3 participants
@parthea@daniel-sanche@vchudnov-g
[8]ページ先頭
©2009-2025 Movatter.jp