Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

fix: Improve transcoding error message in v1 branch#445

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
vam-google merged 1 commit intov1fromsync-v1
Sep 14, 2022
Merged

Conversation

@parthea
Copy link
Collaborator

Port changes from#442 into v1 branch

* fix: Improve transcodding error messageThisfixes#441 and#440. Also, with this change we stop outputting the whole request message in transcodding erro message to prevent leaking any confidential information from a request message in a form of an error in a log message.* reformat code with black
@partheaparthea requested review froma team ascode ownersSeptember 14, 2022 15:02
@product-auto-labelproduct-auto-labelbot added the size: sPull request size is small. labelSep 14, 2022
Copy link
Contributor

@vam-googlevam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@vam-googlevam-google merged commitd0352ca intov1Sep 14, 2022
@vam-googlevam-google deleted the sync-v1 branchSeptember 14, 2022 18:21
@release-pleaserelease-pleasebot mentioned this pull requestSep 14, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@vam-googlevam-googlevam-google approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@vam-googlevam-google

Labels

size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@parthea@vam-google

[8]ページ先頭

©2009-2025 Movatter.jp