Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: merge main branch into v1#438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 113 commits intov1frommerge-main
Sep 6, 2022
Merged

feat: merge main branch into v1#438

parthea merged 113 commits intov1frommerge-main
Sep 6, 2022

Conversation

parthea
Copy link
Collaborator

@partheaparthea commentedSep 6, 2022
edited
Loading

For google-api-core we did not make breaking changes in themain branch beyond removing support for 2.7. This PR ports all of the features from themain branch into thev1 branch.

busunkim96and others added30 commitsAugust 3, 2021 11:47
Drop 'six' moduleDrop 'u"' prefixes for textRemove other Python 2.7 workaroundsDrop use of 'pytz'Dxpand range to allow 'google-auth' 2.x versionsRemove 'general_helpers.wraps': except for a backward-compatibilityimport, 'functools.wraps' does everything wee need on Python >= 3.6.Remove 'packaging' dependencyRelease-As: 2.0.0b1Closes#74.Closes#215.
Source-Link:googleapis/synthtool@7e1f6daPost-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:a1a891041baa4ffbe1a809ac1b8b9b4a71887293c9101c88e8e255943c5aec2d
Rely on the pins in 'setup.py' as the Source of Truth.See#234 (review)
Source-Link:googleapis/synthtool@facee4cPost-Processor: gcr.io/repo-automation-bots/owlbot-python:latest@sha256:9743664022bd63a8084be67f144898314c7ca12f0a03e422ac17c733c129d803Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
🤖 I have created a release \*beep\* \*boop\*---## [2.0.0](https://www.github.com/googleapis/python-api-core/compare/v2.0.0-b1...v2.0.0) (2021-08-18)### ⚠ BREAKING CHANGES* drop support for Python 2.7 / 3.5 ([#212](https://www.github.com/googleapis/python-api-core/issues/212)) ([a30f004](https://www.github.com/googleapis/python-api-core/commit/a30f004e74f709d46e905dd819c71f43354e9ac9))### Bug Fixes* bump grpcio version to use stable aio API ([#234](https://www.github.com/googleapis/python-api-core/issues/234)) ([bdbf889](https://www.github.com/googleapis/python-api-core/commit/bdbf889210b709d7c1945f2160bcba9161b4dd2e))* strip trailing _ from field mask paths ([#228](https://www.github.com/googleapis/python-api-core/issues/228)) ([ff6ef1b](https://www.github.com/googleapis/python-api-core/commit/ff6ef1bd07fa68307b7c82c910416d770e7b3416))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Co-authored-by: Tres Seaver <tseaver@palladion.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Co-authored-by: Tres Seaver <tseaver@palladion.com>
chore: removing owlbot directives for conversion to main
* feat: add grpc transcoding + tests* 🦉 Updates from OwlBotSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* chore: tweak for clarity / idiomatic usage* chore: attempt to appease Sphinx* feat: add grpc transcoding + tests* Add functions to properly handle subfields* Add unit tests for get_field and delete_field.* Add function docstrings and incorporate correct native dict functions.* Add function docstrings and incorporate correct native dict functions.* Increase code coverage* Increase code coverage* Increase code coverage* Reformat filesCo-authored-by: Yonatan Getahun <yonmg@google.com>Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Tres Seaver <tseaver@palladion.com>
chore: relocate owl bot post processor
…282)* chore: add default_version and codeowner_team to .repo-metadata.json* Assign@googleapis/actools-python as codeowner
…le (#283)Source-Link:googleapis/synthtool@a7ed11ePost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:6e7328583be8edd3ba8f35311c76a1ecbc823010279ccb6ab46b7a76e25eafccCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Fix new deprecation warning for 'threading.Condition.notifyAll'.
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@c6e69c4Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:58f73ba196b5414782605236dd0712a73541b44ff2ff4d3a36ec41092dd6fa5bCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
gcf-owl-botbotand others added15 commitsAugust 9, 2022 21:44
* chore(python): drop python 3.6Source-Link:googleapis/synthtool@4f89b13Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:e7bb19d47c13839fe8c147e50e02e8b6cf5da8edd1af8b82208cd6f66cc2829c* require python 3.7+ in setup.py* remove python 3.6 sample configs* exclude templated README* remove python 3.6 from noxfile* remove python 3.6 from remaining files* remove testing/constraints-3.6.txtCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
* chore(deps): update actions/setup-python action to v4* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.mdCo-authored-by: Anthonios Partheniou <partheniou@google.com>Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
ADC login command for gcloud is `gcloud auth application-default auth login`Co-authored-by: Anthonios Partheniou <partheniou@google.com>
…[autoapprove] (#424)Source-Link:googleapis/synthtool@1f37ce7Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:8e84e0e0d71a0d681668461bba02c9e1394c785f31a10ae3470660235b673086Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@69fabaePost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:562802bfac02e012a6ac34eda282f81d06e77326b82a32d7bbb1369ff552b387Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@c4dd595Post-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:ce3c1686bc81145c81dd269bd12c4025c6b275b22d14641358827334fddb1d72Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
…cts (#428)* feat: Make grpc transcode logic work in terms of protobuf python objects(for context: [gRPC Transcoding](https://github.com/googleapis/googleapis/blob/master/google/api/http.proto#L44))Previously it worked on dictionaries only, but that causes problems.In GAPIC the dictionaries are created through the same logic as JSON (there is no better built-in way), thus applying [protobuf json mapping](https://developers.google.com/protocol-buffers/docs/proto3#json) conversion logic in the process. Unfortunately converting a protobuf object to a dictionary and to JSON, although similar, are not the same thing. Specifically the `Timestamp`, `Duration`, `FieldMask`, `uint64`, `int64`, and `*Value` protobuf messages are converted to strings for JSON (instead of being properly converted to dicts for most of those types, and `int64/uint64` converted to `int` respectively). As a result a rountrip that GAPIC was relying on (protobuf object -> dict -> transcode -> protobuf object) did not work properly. For example, when converted to dictionary, every int64 field would be converted to `string` (because it is what proto-JSON mapping spec requires), but later, when we need to rebuild a message from a transcoded dictionary that would fail with the following error:```TypeError: '0' has type str, but expected one of: int```Note, `*Rules` thing from proto-plus does not help, becuase the type may happen inside common native protobuf stub messsages (like `google.type.Money`), fields of which are outside of scope of the proto-plus custom conversion logic.Also, this change greatly simplifies the procedure of transcodding, eliminating multiple conversion steps (to and from dictionaries multiple times) making the whole logic significanly more efficient (python gapics are nutoriously known to be slow due to proto-plus stuff, so efficiency is important) and robust (JSON conversion logic does not interfere anymore with pure protobuf objects grpc transcoding)* reformat code using black* reformat code according to flake8Co-authored-by: Anthonios Partheniou <partheniou@google.com>
…430)Source-Link:googleapis/synthtool@fdba3edPost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:1f0dbd02745fb7cf255563dab5968345989308544e52b7f460deadd5e78e63b0
docs: add a note that grpcio-gcp is only supported in environments with protobuf < 4.x.xdocs: raise DeprecationWarning when 'grpcio-gcp' is usedfix(deps): require protobuf >= 3.20.1
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@703554aPost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:94961fdc5c9ca6d13530a6a414a49d2f607203168215d074cdb0a1df9ec31c0bCo-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
* feat: add 'strict' to flatten_query_params to lower-case bools* pylintCo-authored-by: Anthonios Partheniou <partheniou@google.com>
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
Source-Link:googleapis/synthtool@56da63ePost-Processor: gcr.io/cloud-devrel-public-resources/owlbot-python:latest@sha256:993a058718e84a82fda04c3177e58f0a43281a996c7c395e0a56ccc4d6d210d7
@product-auto-labelproduct-auto-labelbot added the size: lPull request size is large. labelSep 6, 2022
@google-cla
Copy link

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View thisfailed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@parthea
Copy link
CollaboratorAuthor

It should be ok to ignore the CLA in this case, as these commits were already merged in main.

@partheaparthea marked this pull request as ready for reviewSeptember 6, 2022 14:54
@partheaparthea requested review froma team ascode ownersSeptember 6, 2022 14:54
Copy link
Contributor

@vam-googlevam-google left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

LGTM

@partheaparthea merged commita175ce5 intov1Sep 6, 2022
@partheaparthea deleted the merge-main branchSeptember 6, 2022 19:16
@release-pleaserelease-pleasebot mentioned this pull requestSep 6, 2022
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Reviewers

@vam-googlevam-googlevam-google approved these changes

Assignees

@vam-googlevam-google

Labels
size: lPull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

21 participants
@parthea@vam-google@busunkim96@tseaver@lidizheng@nicain@yihjenku@kbandes@SurferJeffAtGoogle@atulep@sushicw@anguillanneuf@arithmetic1728@renovate-bot@software-dov@hugovk@ddoskind@dandhlee@Mariatta@sai-sunder-s@vchudnov-g

[8]ページ先頭

©2009-2025 Movatter.jp