This was discovered inPub/Sub, whereby futures dependent on this class hang if not set with a timeout when a throw occurs inBackgroundConsumer's _thread_main.

When weopen a BackgroundConsumer, if something within the try block, e.g.open, throws, then the exception clauseslog but do not close the underlying stream or thread.

I believe this will be fixed by addingself.stop() when exceptions are caught. This appears consistent with the intent of the classas per the docstring. Then, thebidi_rpc will call ouradd_done_callback to surface the error.

I will be submitting a PR to address this.