- Notifications
You must be signed in to change notification settings - Fork90
fix: memory leak in bidi classes#770
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| @@ -717,6 +719,7 @@ def stop(self): | |||
| _LOGGER.warning("Background thread did not exit.") | |||
| self._thread = None | |||
| self._on_response = None | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This assumes you can't restart an instance after it has been stopped. The test cases and docstrings point to that being the case, but it's not completely clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is a reasonable assumption given that resources should be cleaned up whenclose is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.
| @@ -717,6 +719,7 @@ def stop(self): | |||
| _LOGGER.warning("Background thread did not exit.") | |||
| self._thread = None | |||
| self._on_response = None | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I think this is a reasonable assumption given that resources should be cleaned up whenclose is called. Regardless, we'll publish a pre-release to get feedback on this change before publishing a normal release.
c1b8afa intomainUh oh!
There was an error while loading.Please reload this page.
Thanks@daniel-sanche ! |
Fixes#769