- Notifications
You must be signed in to change notification settings - Fork90
feat: update recognized logging fields#766
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
google/api_core/client_logging.py Outdated
| "httpRequestMethod", | ||
| "httpRequestUrl" "rpcName", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
As perhttps://cloud.google.com/logging/docs/structured-logging#structured_logging_special_fields,httpRequest should be of typeHttpRequest,which includes the fieldsrequestMethod andrequestURL internally.
| "httpRequestMethod", | |
| "httpRequestUrl""rpcName", | |
| "rpcName", |
| @@ -15,12 +15,13 @@ | |||
| "rpcName", | |||
| "serviceName", | |||
| "credentialsType", | |||
| "credentialInfo", | |||
| "credentialsInfo", | |||
| "universeDomain", | |||
| "request", | |||
| "response", | |||
| "metadata", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Per the parent design doc, we should still haverpcName, right? (We're using it in the pending PR in the generator)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Yes we should. I see it here it in the list. Let me know if you see otherwise.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, my bad. Don't know why I didn't see it before.
| @@ -15,12 +15,13 @@ | |||
| "rpcName", | |||
| "serviceName", | |||
| "credentialsType", | |||
| "credentialInfo", | |||
| "credentialsInfo", | |||
| "universeDomain", | |||
| "request", | |||
| "response", | |||
| "metadata", | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Oh, my bad. Don't know why I didn't see it before.
5f80f77 intomainUh oh!
There was an error while loading.Please reload this page.
No description provided.