NotificationsYou must be signed in to change notification settings
Fork90
Star131

fix: Improve`Any` decode error#712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Merged

parthea merged 7 commits intogoogleapis:mainfromMarkDaoust:any-error

Oct 22, 2024

Merged

fix: Improve`Any` decode error#712

parthea merged 7 commits intogoogleapis:mainfromMarkDaoust:any-error

Oct 22, 2024

Conversation

Copy link

Contributor

MarkDaoust commentedOct 1, 2024•
edited
Loading

Was (useless):

TypeError: Could not convert Any to TimeOfDay

Now:

TypeError: Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue:from_any_pb gives a useless error message when the type names don't match. #711
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes#711 🦕

Improve Any decoding-error.

9e01e2e

Was:TypeError: Could not convert Any to PredictLongRunningResponseNow:TypeError: Could not convert   Any[google.ai.generativelanguage.v1main.PredictLongRunningResponse] to       google.ai.generativelanguage.v1beta.PredictLongRunningResponse

MarkDaoust requested review froma team ascode owners

October 1, 2024 23:53

product-auto-labelbot added the size: xsPull request size is extra small. label

Oct 1, 2024

blunderbuss-gcfbot assignedvchudnov-g

Oct 1, 2024

Copy link

Contributor

ohmayr commentedOct 4, 2024

@MarkDaoust Hmm looking at your comment above, is this right syntaxAny[google.ai.generativelanguage.v1main.PredictLongRunningResponse] for Python?

ohmayr reviewed

Oct 4, 2024

View reviewed changes

google/api_core/protobuf_helpers.py OutdatedShow resolvedHide resolved

ohmayr changed the title~~Improve Any decoding-error.~~chore: ImproveAny decode error

Oct 4, 2024

Copy link

conventional-commit-lint-gcfbot commentedOct 4, 2024

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or useautomerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

parthea self-assigned this

Oct 9, 2024

Merge branch 'main' into any-error

acb97ca

parthea changed the title~~chore: ImproveAny decode error~~fix: ImproveAny decode error

Oct 9, 2024

update test

7f9a7b9

product-auto-labelbot added size: sPull request size is small. and removed size: xsPull request size is extra small. labels

Oct 9, 2024

parthea assignedohmayr and unassignedparthea andvchudnov-g

Oct 9, 2024

parthea requested a review fromohmayr

October 9, 2024 17:06

parthea added the process: review requested label

Oct 9, 2024

parthea added2 commits

October 9, 2024 17:30

update error message

7bce39d

Merge branch 'main' into any-error

7a1e1d0

ohmayr approved these changes

Oct 21, 2024

View reviewed changes

tests/unit/test_protobuf_helpers.py Outdated

		with pytest.raises(
		TypeError,
		match=re.escape(
		"Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`"

Copy link

Contributor

ohmayrOct 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Am I reading this correct or should it instead be the following? (My assumption is that the underlying type should beAny).

Suggested change

	"Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`"
	"Could not convert `google.type.Date` with underlying type `google.protobuf.any_pb2.Any` to `google.type.TimeOfDay`"