- Notifications
You must be signed in to change notification settings - Fork95
fix: fix broken import for google.api_core.retry_async.AsyncRetry#587
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
…nary_async.AsyncRetry
| "if_exception_type", | ||
| "if_transient_error", | ||
| "retry_target", | ||
| ) |
daniel-sancheJan 30, 2024 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
This could also be potentially fixed with a file atgoogle/api_core/retry_async.py, right?
Either way works for me, but it does seem like it could be confusing to have aretry_async folder, even though the actual async implementation is in/retry.
Using aretry_async.py file mirrors the old implementation, which feels slightly cleaner to me
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed in4f01471
potiuk commentedJan 30, 2024
Nice! Super speedy one it seems :D. Thanks for handling it that quickly :D |
Fixes#586 🦕