Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix: add warning to retry target to avoid incorrect usage#543

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
ohmayr merged 4 commits intomainfromadd-warning-to-retry
Nov 3, 2023

Conversation

@ohmayr
Copy link
Contributor

Fixes#542 🦕

@ohmayrohmayr requested review froma team ascode ownersOctober 26, 2023 01:07
@product-auto-labelproduct-auto-labelbot added the size: xsPull request size is extra small. labelOct 26, 2023
@ohmayrohmayrforce-pushed theadd-warning-to-retry branch 5 times, most recently from29a7c83 tof5eb290CompareOctober 26, 2023 19:51
@product-auto-labelproduct-auto-labelbot added size: sPull request size is small. and removed size: xsPull request size is extra small. labelsOct 26, 2023
@ohmayrohmayr changed the titleadd warning to retry_target to avoid incorrect usageadd warning to retry target to avoid incorrect usageOct 26, 2023
@ohmayrohmayr changed the titleadd warning to retry target to avoid incorrect usagefix: add warning to retry target to avoid incorrect usageOct 26, 2023
@ohmayrohmayrforce-pushed theadd-warning-to-retry branch 6 times, most recently from95bcc0f to12d5c35CompareOctober 27, 2023 00:22
@ohmayrohmayrforce-pushed theadd-warning-to-retry branch 2 times, most recently from4e04b7d to11b5e02CompareOctober 27, 2023 17:21
Copy link
Contributor

@vchudnov-gvchudnov-g left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

It's looking good, but just a few questions/comments.

@ohmayrohmayr merged commitbfb40e6 intomainNov 3, 2023
@ohmayrohmayr deleted the add-warning-to-retry branchNovember 3, 2023 19:30
@release-pleaserelease-pleasebot mentioned this pull requestNov 3, 2023
This was referencedMay 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@vchudnov-gvchudnov-gvchudnov-g approved these changes

Assignees

No one assigned

Labels

size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Raise a warning in google.api_core.retry.retry_target if the return value is awaitable

2 participants

@ohmayr@vchudnov-g
[8]ページ先頭
©2009-2025 Movatter.jp