- Notifications
You must be signed in to change notification settings - Fork95
fix: drop usage of distutils#541
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Uh oh!
There was an error while loading.Please reload this page.
Conversation
vchudnov-g left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Only a minor, non-blocking comment.
| util.strtobool(os.getenv("GOOGLE_API_USE_CLIENT_CERTIFICATE","false")) | ||
| ) | ||
| use_client_cert=os.getenv("GOOGLE_API_USE_CLIENT_CERTIFICATE","false") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Might as well uslower() in this assignment so you don't have to repeat it below
(It would be great to cast this to a bool like the previous code was doing, but it seems like too much overhead for the very limited use in a very compact LOC range. The string comparison is OK.)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Fixed in614150d
Fixes#507 🦕
ValueErrorif the format of theGOOGLE_API_USE_CLIENT_CERTIFICATEis not as defined belowpython-api-core/google/api_core/operations_v1/abstract_operations_client.py
Lines 275 to 280 in405272c
This is the same behaviour that exists in
gapic-generator-pythonherehttps://github.com/googleapis/gapic-generator-python/blob/45f18a69454bcff68c0f98535c68fbdb4e09db1d/gapic/templates/%25namespace/%25name_%25version/%25sub/services/%25service/client.py.j2#L253-L256