Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat: add support for Python 3.11#466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
parthea merged 9 commits intogoogleapis:mainfromziegenberg:add-python-3-11-support
Nov 10, 2022

Conversation

@ziegenberg
Copy link
Contributor

@ziegenbergziegenberg commentedNov 8, 2022•
edited
Loading

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes#467 🦕

@ziegenbergziegenberg requested review froma team ascode ownersNovember 8, 2022 22:47
@product-auto-labelproduct-auto-labelbot added the size: sPull request size is small. labelNov 8, 2022
@dandhlee
Copy link
Contributor

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

@ziegenberg
Copy link
ContributorAuthor

Hi there, it doesn't seem like you're working with Google. Could you open a GitHub issue first?

That's right; I do work with Google. I will open an issue.

I followed#284 when creating this PR, which also did not have an accompanying issue.

Signed-off-by: Daniel Ziegenberg <daniel@ziegenberg.at>
@ziegenberg
Copy link
ContributorAuthor

Thepython -m py.test call had to be changed topython -m pytest, otherwise it would always fail with:

Error while finding module specification for 'py.test' (ModuleNotFoundError: __path__ attribute not found on 'py' while trying to find 'py.test')

@ziegenberg
Copy link
ContributorAuthor

If it's okay with you, I would rebase my PR onto the current main. That should solve theCommit message did not follow Conventional Commits error.

Copy link
Collaborator

@partheaparthea left a comment•
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

I found that the minimum version ofgrpcio is 1.49.1 for python 3.11. I've updated the setup.py to reflect that.

@partheaparthea changed the titleadd support for Python 3.11feat: add support for Python 3.11Nov 10, 2022
@partheaparthea merged commitff379e3 intogoogleapis:mainNov 10, 2022
@parthea
Copy link
Collaborator

Thanks@ziegenberg!

@ziegenbergziegenberg deleted the add-python-3-11-support branchNovember 10, 2022 16:42
This was referencedMay 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@partheapartheaparthea approved these changes

Assignees

No one assigned

Labels

size: sPull request size is small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

add support for Python 3.11

3 participants

@ziegenberg@dandhlee@parthea
[8]ページ先頭
©2009-2025 Movatter.jp