Movatterモバイル変換


[0]ホーム

URL:


Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Sign up
Appearance settings

feat: add iterator capability to paged iterators#200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 2 commits intogoogleapis:masterfromplamut:iss-175
Jun 8, 2021

Conversation

@plamut
Copy link
Contributor

Closes#175.

This PR transforms *Iterator classes to actual iterators (before they were justiterables).

PR checklist:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

tswast reacted with hooray emoji
The *Iterator classes are only _iterables_, and this commit also makesthem _iterators_, i.e. calling next(iterator) on them now works.
@plamutplamut requested a review fromtswastJune 7, 2021 12:49
@plamutplamut requested a review froma team as acode ownerJune 7, 2021 12:49
@google-clagoogle-clabot added the cla: yesThis human has signed the Contributor License Agreement. labelJun 7, 2021
@plamutplamut merged commit3487d68 intogoogleapis:masterJun 8, 2021
@plamutplamut deleted the iss-175 branchJune 8, 2021 08:30
This was referencedMay 30, 2025
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswastAwaiting requested review from tswast

1 more reviewer

@tseavertseavertseaver approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

paged iterators are not iterators

2 participants

@plamut@tseaver

[8]ページ先頭

©2009-2025 Movatter.jp