- Notifications
You must be signed in to change notification settings - Fork89
Comparing changes
Open a pull request
base repository:googleapis/python-api-core
Uh oh!
There was an error while loading.Please reload this page.
base:v2.19.0
head repository:googleapis/python-api-core
Uh oh!
There was an error while loading.Please reload this page.
compare:v2.19.1
- 9commits
- 14files changed
- 6contributors
Commits on May 3, 2024
chore: avoid checking instance on each stream call (#529)
* chore: avoid checking instance on each stream call* fixed indentation* added check for unary call* fixed type check* fixed tests* fixed coverage* added exception to test class* added comment to test* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
feat: add caching to GapicCallable (#527)
* feat: optimize _GapicCallable* cleaned up metadata lines* chore: avoid type checks in error wrapper* Revert "chore: avoid type checks in error wrapper"This reverts commitc97a636.* add default wrapped function* fixed decorator order* fixed spacing* fixed comment typo* fixed spacing* fixed spacing* removed unneeded helpers* use caching* improved metadata parsing* improved docstring* fixed logic* added benchmark test* update threshold* run benchmark in loop for testing* use verbose logs* Revert testing* used smaller value* changed threshold* removed link in comment
Commits on Jun 4, 2024
chore: fallback to unary_unary when wrapping async callables (#653)
* fix: fallback to unary_unary when wrapping async callablesWe recently [made a change](ab22afd) to move some computation in the async rpc wrapper from call-time to wrap-time. This way, individual calls would execute faster, since they don't have to re-compute some data on each callA side-effect of this change is that now some [type validation](https://github.com/googleapis/python-api-core/blob/d96eb5cdd8120bfec97d62b09512c6fecc325be8/google/api_core/grpc_helpers_async.py#L209) happens earlier. This caused some downstream tests to fail when a mock grpc channel is used. The wrapper doesn't know how to handle the mock.Mock type, and raises an exception while constructing the client objectThis PR fixes the issue by falling back to the unary wrapper when the callable type is unknown, rather than raising an exception. This is in-line with how [the sync version handles it](https://github.com/googleapis/python-api-core/blob/d96eb5cdd8120bfec97d62b09512c6fecc325be8/google/api_core/grpc_helpers.py#L198)* fixed elif to if* removed outdated test
fix: Ignore unknown fields in rest streaming. (#651)
* Ignore unknown fields in rest streaming.If the api adds a new field to a stremaing response, it shouldn't break old clients.We found this in the google.ai.generativelanguage API. Colab forces our clients to use rest, so all our streaming examples broke when the API team rolled out a new field.* format---------Co-authored-by: Anthonios Partheniou <partheniou@google.com>
chore: move retry async check to wrap time (#649)
* chore: move retry async check to wrap time* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* added no cover mark---------Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>Co-authored-by: Anthonios Partheniou <partheniou@google.com>
chore(revert): Revert "feat: add caching to GapicCallable" (#665)
This reverts commitd96eb5c.
Commits on Jun 5, 2024
Commits on Jun 19, 2024
fix: add support for protobuf 5.x (#644)
* fix: add support for protobuf 5.x* remove pin for types-protobuf* remove pytest from noxfile* refactor common code* RefactorCo-authored-by: Victor Chudnovsky <vchudnov@google.com>* run black* 🦉 Updates from OwlBot post-processorSeehttps://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md* mypy* run pre-release test against all python versions* filter warning---------Co-authored-by: Victor Chudnovsky <vchudnov@google.com>Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Commits on Jun 24, 2024
chore(main): release 2.19.1 (#650)
Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com>
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:git diff v2.19.0...v2.19.1
Uh oh!
There was an error while loading.Please reload this page.