NotificationsYou must be signed in to change notification settings
Fork95
Star145

Commitffa528e

authored

chore: avoid duplicating pins of grpcio in noxfile (#246)

Rely on the pins in 'setup.py' as the Source of Truth.See#234 (review)

1 parent258ba4a commitffa528eCopy full SHA for ffa528e

File tree

1 file changed

-8

lines changed

noxfile.py

1 file changed

-8

lines changed

`‎noxfile.py‎`

Lines changed: 5 additions & 8 deletions

Original file line number	Diff line number	Diff line change
`@@ -80,8 +80,8 @@ def default(session):`
`80`	`80`	`)`
`81`	`81`
`82`	`82`	`# Install all test dependencies, then install this package in-place.`
`83`		`-session.install("mock","pytest","pytest-cov","grpcio >= 1.0.2")`
`84`		`-session.install("-e",".","-c",constraints_path)`
	`83`	`+session.install("mock","pytest","pytest-cov")`
	`84`	`+session.install("-e",".[grpc]","-c",constraints_path)`
`85`	`85`
`86`	`86`	`pytest_args= [`
`87`	`87`	`"python",`
`@@ -124,7 +124,7 @@ def unit_grpc_gcp(session):`
`124`	`124`	`CURRENT_DIRECTORY/"testing"/f"constraints-{session.python}.txt"`
`125`	`125`	`)`
`126`	`126`	`# Install grpcio-gcp`
`127`		`-session.install("grpcio-gcp","-c",constraints_path)`
	`127`	`+session.install("-e",".[grpcgcp]","-c",constraints_path)`
`128`	`128`
`129`	`129`	`default(session)`
`130`	`130`
`@@ -141,9 +141,7 @@ def lint_setup_py(session):`
`141`	`141`	`@nox.session(python="3.6")`
`142`	`142`	`defpytype(session):`
`143`	`143`	`"""Run type-checking."""`
`144`		`-session.install(`
`145`		`-".","grpcio >= 1.8.2","grpcio-gcp >= 0.2.2","pytype >= 2019.3.21"`
`146`		`- )`
	`144`	`+session.install(".[grpc, grpcgcp]","pytype >= 2019.3.21")`
`147`	`145`	`session.run("pytype")`
`148`	`146`
`149`	`147`
`@@ -163,8 +161,7 @@ def cover(session):`
`163`	`161`	`defdocs(session):`
`164`	`162`	`"""Build the docs for this library."""`
`165`	`163`
`166`		`-session.install(".","grpcio >= 1.8.2","grpcio-gcp >= 0.2.2")`
`167`		`-session.install("-e",".")`
	`164`	`+session.install("-e",".[grpc, grpcgcp]")`
`168`	`165`	`session.install("sphinx==4.0.1","alabaster","recommonmark")`
`169`	`166`
`170`	`167`	`shutil.rmtree(os.path.join("docs","_build"),ignore_errors=True)`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commitffa528e

File tree

1 file changed

1 file changed

`‎noxfile.py‎`

0 commit comments