Commitdc33849

committed

address review feedback

1 parent7a1e1d0 commitdc33849Copy full SHA for dc33849

File tree

-2

lines changed

-2

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -63,7 +63,7 @@ def from_any_pb(pb_type, any_pb):`
`63`	`63`	`# Unpack the Any object and populate the protobuf message instance.`
`64`	`64`	`ifnotany_pb.Unpack(msg_pb):`
`65`	`65`	`raiseTypeError(`
`66`		-f"Could not convert `google.protobuf.any_pb2.Any` with underlying type `{any_pb.TypeName()}` to `{msg_pb.DESCRIPTOR.full_name}`"
	`66`	+f"Could not convert `{any_pb.TypeName()}` with underlying type `google.protobuf.any_pb2.Any` to `{msg_pb.DESCRIPTOR.full_name}`"
`67`	`67`	`)`
`68`	`68`
`69`	`69`	`# Done; return the message.`

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -69,7 +69,7 @@ def test_from_any_pb_failure():`
`69`	`69`	`withpytest.raises(`
`70`	`70`	`TypeError,`
`71`	`71`	`match=re.escape(`
`72`		-"Could not convert `google.protobuf.any_pb2.Any` with underlying type `google.type.Date` to `google.type.TimeOfDay`"
	`72`	+"Could not convert `google.type.Date` with underlying type `google.protobuf.any_pb2.Any` to `google.type.TimeOfDay`"
`73`	`73`	`),`
`74`	`74`	`):`
`75`	`75`	`protobuf_helpers.from_any_pb(timeofday_pb2.TimeOfDay,in_message)`

Comments

(0)