Commit7727405

authored

chore: Revert "chore: move retry async check to wrap time (#668)" (#743)

This reverts commit3c69867.

1 parent0d5ed37 commit7727405Copy full SHA for 7727405

File tree

-14

lines changed

-14

lines changed

Lines changed: 4 additions & 3 deletions

Original file line number	Diff line number	Diff line change
`@@ -141,7 +141,10 @@ def retry_target(`
`141`	`141`
`142`	`142`	`forsleepinsleep_generator:`
`143`	`143`	`try:`
`144`		`-returntarget()`
	`144`	`+result=target()`
	`145`	`+ifinspect.isawaitable(result):`
	`146`	`+warnings.warn(_ASYNC_RETRY_WARNING)`
	`147`	`+returnresult`
`145`	`148`
`146`	`149`	`# pylint: disable=broad-except`
`147`	`150`	`# This function explicitly must deal with broad exceptions.`
`@@ -277,8 +280,6 @@ def __call__(`
`277`	`280`	Callable: A callable that will invoke ``func`` with retry
`278`	`281`	`behavior.`
`279`	`282`	`"""`
`280`		`-ifinspect.iscoroutinefunction(func):`
`281`		`-warnings.warn(_ASYNC_RETRY_WARNING)`
`282`	`283`	`ifself._on_errorisnotNone:`
`283`	`284`	`on_error=self._on_error`
`284`	`285`

Lines changed: 5 additions & 11 deletions

Original file line number	Diff line number	Diff line change
`@@ -105,20 +105,14 @@ def test_retry_target_non_retryable_error(utcnow, sleep):`
`105`	`105`	`)`
`106`	`106`	`@pytest.mark.asyncio`
`107`	`107`	`asyncdeftest_retry_target_warning_for_retry(utcnow,sleep):`
`108`		`-"""`
`109`		`- retry.Retry should raise warning when wrapping an async function.`
`110`		`- """`
`111`		`-`
`112`		`-asyncdeftarget():`
`113`		`-pass# pragma: NO COVER`
`114`		`-`
`115`		`-retry_obj=retry.Retry()`
	`108`	`+predicate=retry.if_exception_type(ValueError)`
	`109`	`+target=mock.AsyncMock(spec=["__call__"])`
`116`	`110`
`117`	`111`	`withpytest.warns(Warning)asexc_info:`
`118`		`-#raise warning when wrapping an async function`
`119`		`-retry_obj(target)`
	`112`	`+#Note: predicate is just a filler and doesn't affect the test`
	`113`	`+retry.retry_target(target,predicate,range(10),None)`
`120`	`114`
`121`		`-assertlen(exc_info)==1`
	`115`	`+assertlen(exc_info)==2`
`122`	`116`	`assertstr(exc_info[0].message)==retry.retry_unary._ASYNC_RETRY_WARNING`
`123`	`117`	`sleep.assert_not_called()`
`124`	`118`

Comments

(0)