- Notifications
You must be signed in to change notification settings - Fork108
feat: await/catch promises, and update listOperationsAsync return type#1382
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
danieljbruce wants to merge22 commits intomainChoose a base branch
base:main
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
…nd query resultsPiperOrigin-RevId: 635449160Source-Link:googleapis/googleapis@dde0ec1Source-Link:googleapis/googleapis-gen@8caa60dCopy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiOGNhYTYwZDlhZWE4Mjk2NGExOWNkZjhmYWY5MTM4NDkxMWRiOGJkZCJ9
feat: specify retry configurationPiperOrigin-RevId: 712493958Source-Link:googleapis/googleapis@29aea41Source-Link:googleapis/googleapis-gen@04bcbabCopy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMDRiY2JhYjQ1MDU5ODllOTg0YjE0MDNkNDM4ZmZmYzAzMTIxNDRhZiJ9
fix: add x-goog-request params to headers for LRO-polling methodsfix: remove extra protos in ESM & capture ESM in headersdocs: update comments for a Nodejs stream objectPiperOrigin-RevId: 721038181Source-Link:googleapis/googleapis@331a41aSource-Link:googleapis/googleapis-gen@e81b4c5Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZTgxYjRjNWI1MjA4ODk1ZjY2M2EyNDA0ODYxNWE1OWQ1NjM2ZjQxNSJ9
PiperOrigin-RevId: 723181578Source-Link:googleapis/googleapis@c7b69f4Source-Link:googleapis/googleapis-gen@d1bc1acCopy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZDFiYzFhY2Q3NDI5NjQyMmE1Y2I2ZTBjNDAxNmM4YzQ4ZTk5ODUzOCJ9
PiperOrigin-RevId: 723563760Source-Link:googleapis/googleapis@2f843e2Source-Link:googleapis/googleapis-gen@cd0f9c6Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiY2QwZjljNmZlMWRkNzdjNTUyZWY3NjZlNjA0N2Y4ZGNmZDNiY2MyZSJ9
PiperOrigin-RevId: 731738802Source-Link:googleapis/googleapis@d72ca0dSource-Link:googleapis/googleapis-gen@2734992Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjczNDk5MjBkYWU2Y2Q0YzJhNTFjMWM1YjRiNDNlMmMwMGYwMjk2NiJ9
PiperOrigin-RevId: 732130682Source-Link:googleapis/googleapis@9415ba0Source-Link:googleapis/googleapis-gen@2905f83Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwNWY4MzM3NTZjMmIyMGIzMjgyYmU4NGI1MTFlMDQwZmU1NGYzMyJ9
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671)fix: add json files to tsconfig templates (#1692) (ba6be1d)PiperOrigin-RevId: 735896588Source-Link:googleapis/googleapis@3419af7Source-Link:googleapis/googleapis-gen@f35ba11Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9
PiperOrigin-RevId: 738212310Source-Link:googleapis/googleapis@803b234Source-Link:googleapis/googleapis-gen@4f44bd2Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9
…atastore into owl-bot-copy# Conflicts:#protos/google/datastore/v1/datastore.proto#protos/protos.d.ts#protos/protos.js#protos/protos.json
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: datastoreIssues related to the googleapis/nodejs-datastore API. size: xlPull request size is extra large.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The goal is to merge the changes currently on
owl-bot-copyfromthis PR to prepare for the Node 18 migration. To solve some linting errors, the version of google-gax was upgraded and then to solve some test errors we needed to rely on an older version of protobuf than the one we currently use in google-gax.