- Notifications
You must be signed in to change notification settings - Fork32
feat: simplifyToolboxToolset lazy init and use private attributes#472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
anubhav756 wants to merge18 commits intodocs/toolbox-adk-readmeChoose a base branch
base:docs/toolbox-adk-readme
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ToolboxToolset lazy init and use private attributes35e2f79 to33d0c1cComparec52302d to0b8602cComparea577def toed9d26dCompare…NTITYAlso fixed broken imports in __init__.py and client.py
ed9d26d to8825e66CompareImplements the ToolboxToolset class in toolbox-adk.- Wraps ToolboxClient to provide tools to ADK agents.- Supports all standard credential strategies.- Adds support for auth_token_getters to handle tools with custom authSources (runtime token resolution).- Includes unit tests for toolset functionality.
Adds a comprehensive integration test suite for toolbox-adk matching toolbox-core coverage.- Basic E2E: Loading toolsets, running tools.- Parameters: Bound parameters, Map parameters, Optional parameters.- Authentication: Verifies auth_token_getters propagation and error handling.- Input Validation: Verifies correct error types for missing/invalid inputs.
Adds factory methods to CredentialStrategy to easily create configurations from ADK objects.- from_adk_auth_config(auth_config)- from_adk_credentials(scheme, credential)ENSURES strict consistency between ADK auth types and Toolbox credential requirements.
Adds factory methods to CredentialStrategy to easily create configurations from ADK objects.- from_adk_auth_config(auth_config)- from_adk_credentials(scheme, credential)ENSURES strict consistency between ADK auth types and Toolbox credential requirements.
Adds factory methods to CredentialStrategy to easily create configurations from ADK objects.- from_adk_auth_config(auth_config)- from_adk_credentials(scheme, credential)ENSURES strict consistency between ADK auth types and Toolbox credential requirements.
e542e08 to19487caCompare19487ca toee00c24CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
This PR refactors
ToolboxToolsetto use private attributes for internal state and implements lazy initialization for theclientproperty to preventRuntimeErrorduring global instantiation. This ensures a singleton client pattern while maintaining thread safety during import.