- Notifications
You must be signed in to change notification settings - Fork32
test(toolbox-adk): Implement parity integration tests#458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
anubhav756 wants to merge1 commit intofeature/tool_wrapperChoose a base branch
base:feature/tool_wrapper
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
+791 −7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f0d3b2e tof2805d0Compared0f7fe2 toa4e9134Comparef2805d0 to637fbbdComparea4e9134 to044c10bCompare637fbbd to2a21fb9Comparef22f8e8 tobca0d6bCompare744e231 to906bdaeComparef3f04ce to26f3984Compare906bdae to807700eCompare26f3984 tobdf083aCompare807700e tof46c0d8Comparebdf083a to01d778cComparef46c0d8 to304cd40Compare01d778c to30bae1cCompare304cd40 tob52f06aCompare30bae1c tobb190a8Compareb52f06a to93a9455Comparebb190a8 tobea7d46Compare93a9455 to9de5418Comparebea7d46 tob1d7127Compare9de5418 to01fa7beCompareb1d7127 to8e540a1Compare01fa7be to35302dbCompare30ebfe2 to606c00bCompare This was referencedDec 12, 2025
606c00b to506b8ccCompare4cf2b58 to24f5dddCompare75c8ed3 to5b53949Compare24f5ddd toca00852Compare5b53949 to4ff24faCompare| raisee | ||
| logging.warning( | ||
| f"Unexpected error in get_auth_response during 3LO retrieval:{e}. " |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
nit:3LO will be unclear for most users
averikitsch approved these changesDec 19, 2025
ca00852 tobcae4aaCompare6dd40e6 toa0024f4Compare96b27e5 to9d58e95Comparea0024f4 to4d62f08Compare9d58e95 to1e13d13Compare4d62f08 tob2918b5Compare1e13d13 tob30e1b6Compareb2918b5 toc7cb569Compareb30e1b6 to71cc332Comparec7cb569 to65530f5CompareAdds a comprehensive integration test suite for toolbox-adk matching toolbox-core coverage.- Basic E2E: Loading toolsets, running tools.- Parameters: Bound parameters, Map parameters, Optional parameters.- Authentication: Verifies auth_token_getters propagation and error handling.- Input Validation: Verifies correct error types for missing/invalid inputs.
71cc332 toe4e0457Compare65530f5 toa102b70CompareSign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Adds a comprehensive integration test suite for
toolbox-adk.auth_token_getterspropagation and error handling.