- Notifications
You must be signed in to change notification settings - Fork32
feat(adk): Implement tool wrapper & auth getters#457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Open
anubhav756 wants to merge1 commit intofeature/client_wrapperChoose a base branch
base:feature/client_wrapper
Could not load branches
Branch not found:{{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline, and old review comments may become outdated.
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
f0d3b2e tof2805d0Compare269dc5c to0535010Comparef2805d0 to637fbbdCompare0f409ca to934b989Compare637fbbd to2a21fb9Compare934b989 to9cef2caCompare744e231 to906bdaeCompare9cef2ca to79b8a25Compare906bdae to807700eCompare79b8a25 tod0f84a4Compare807700e tof46c0d8Compared0f84a4 to1fa2d2cComparef46c0d8 to304cd40Compare1fa2d2c toaaf8403Compare9de5418 to01fa7beComparefc1d045 to6da9092Compare35302db to649c8b0Comparea82d085 to9922131Compare649c8b0 tocce2235Compare9922131 to460092eComparecce2235 to7a951faComparedc204cd to5d1026fCompare1218555 to5d54030Compare5d1026f to3b67c27Compare5d54030 to7e000e2Compare3b67c27 to8d45254Compare7e000e2 to9f43f3aCompare8d45254 to9497125Compare9f43f3a tob92c624Compare24f5ddd toca00852Compareca00852 tobcae4aaCompareb92c624 to6d8b45fComparebcae4aa to96b27e5Compare529edcd to1ec0dc0Compare96b27e5 to9d58e95Compare1ec0dc0 to2be21eaCompare9d58e95 to1e13d13Compare2be21ea to2e9551fCompare1e13d13 tob30e1b6Compare2e9551f to0328f92Compareb30e1b6 to71cc332CompareImplements the ToolboxToolset class in toolbox-adk.- Wraps ToolboxClient to provide tools to ADK agents.- Supports all standard credential strategies.- Adds support for auth_token_getters to handle tools with custom authSources (runtime token resolution).- Includes unit tests for toolset functionality.
0328f92 to4f02037Compare71cc332 toe4e0457Compare| # We act as a proxy. | ||
| # We need to extract metadata from the core tool to satisfy BaseTool's contract. | ||
| name=getattr(core_tool,"__name__","unknown_tool") |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Should we error if no name or description is found?
| # Check if we already have credentials from a previous exchange | ||
| try: | ||
| # get_auth_response returns AuthCredential if found | ||
| ctx_any=cast(Any,tool_context) |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Why are we casting to Any?
| from .credentialsimportCredentialConfig,CredentialType | ||
| classToolboxContext: |
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
I left a thought on the design doc for context and hooks.
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
None yet
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Implements the
ToolboxToolsetclass intoolbox-adk.ToolboxClientto provide tools to ADK agents.auth_token_gettersto handle tools with customauthSources(runtime token resolution).