- Notifications
You must be signed in to change notification settings - Fork32
tests(langchain-sdk): Update conftest to be able to run tests in local#18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
base:main
Are you sure you want to change the base?
Uh oh!
There was an error while loading.Please reload this page.
Conversation
| credentials.refresh(request) | ||
| returncredentials.token | ||
| try: | ||
| # Try getting the token using gcloud (for local development) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Kurtis' comment from the other PR:
I'm not sure I agree with this flow. I think ideally it should be trying the metadata server first, and falling back to gcloud if it's unable to reach. An alternative would be use an env var to signal which to use.
Ideally, we should not rely on "gcloud auth" as it's not semantically versioned (and I've personally been bit by it changing int the past)
Getting an id token from metadata server does not work on local systems. This causes test failures for auth tests locally. This PR fixes the issue.
This unblockshttps://b.corp.google.com/issues/385051620