- Notifications
You must be signed in to change notification settings - Fork90
Comments
fix: update PCU request building logic to properly clear crc32c and md5#3323
Merged
BenWhitehead merged 1 commit intomainfromOct 3, 2025
Merged
fix: update PCU request building logic to properly clear crc32c and md5#3323BenWhitehead merged 1 commit intomainfrom
BenWhitehead merged 1 commit intomainfrom
Conversation
If a PCU is initiated with a BlobInfo from the current generation of an object, the crc32c and md5 will be included in all compose requests. Update the code to properly clear when necessary, and to only apply a provided value to the final compose if crc32cMatch or md5Match were specified.
bajajneha27 approved these changesOct 3, 2025
4da9f31 intomain 25 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If a PCU is initiated with a BlobInfo from the current generation of an object, the crc32c and md5 will be included in all compose requests. Update the code to properly clear when necessary, and to only apply a provided value to the final compose if crc32cMatch or md5Match were specified.