- Notifications
You must be signed in to change notification settings - Fork90
Comments
fix: update gRPC implementation for storage.buckets.get to translate NOT_FOUND to null#3005
Merged
BenWhitehead merged 1 commit intomainfromMar 20, 2025
Merged
Conversation
…NOT_FOUND to nullStorageImpl will return null if a bucket is not found, this updates GrpcStorageImpl to do the same.
cojenco approved these changesMar 20, 2025
ddelgrosso1 approved these changesMar 20, 2025
704af65 intomain 20 of 21 checks passed
Uh oh!
There was an error while loading.Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
StorageImpl will return null if a bucket is not found, this updates GrpcStorageImpl to do the same.