Commit9e6cbf1

authored

fix(java): java 17 dependency arguments (#1266) (#538)

1 parent525b936 commit9e6cbf1Copy full SHA for 9e6cbf1

File tree

-9

lines changed

-9

lines changed

Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
`@@ -1,3 +1,3 @@`
`1`	`1`	`docker:`
`2`	`2`	`image:gcr.io/cloud-devrel-public-resources/owlbot-java:latest`
`3`		`-digest:sha256:d4b2141d65566523dfd523f63c6e6899ab1281463bce182a9f600e74b0511875`
	`3`	`+digest:sha256:a3ac08d167454718ff057b97a1950d3cb5e16fc39fb3f355d90276285a6cac75`

Lines changed: 4 additions & 6 deletions

Original file line number	Diff line number	Diff line change
`@@ -38,15 +38,13 @@ function determineMavenOpts() {`
`38`	`38`	`\| sed -E's/^(1\.[0-9]\.0).*$/\1/g'`
`39`	`39`	`)`
`40`	`40`
`41`		`-case$javaVersionin`
`42`		`-"17")`
	`41`	`+if [[$javaVersion== 17* ]]`
	`42`	`+then`
`43`	`43`	`# MaxPermSize is no longer supported as of jdk 17`
`44`	`44`	`echo -n"-Xmx1024m"`
`45`		`- ;;`
`46`		`-*)`
	`45`	`+else`
`47`	`46`	`echo -n"-Xmx1024m -XX:MaxPermSize=128m"`
`48`		`- ;;`
`49`		`-esac`
	`47`	`+fi`
`50`	`48`	`}`
`51`	`49`
`52`	`50`	`export MAVEN_OPTS=$(determineMavenOpts)`

Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -56,13 +56,13 @@ implementation 'com.google.cloud:google-cloud-redis'`
`56`	`56`	`If you are using Gradle without BOM, add this to your dependencies`
`57`	`57`
`58`	`58`	```Groovy
`59`		`-implementation 'com.google.cloud:google-cloud-redis:2.0.5'`
	`59`	`+implementation 'com.google.cloud:google-cloud-redis:2.0.6'`
`60`	`60`	```
`61`	`61`
`62`	`62`	`If you are using SBT, add this to your dependencies`
`63`	`63`
`64`	`64`	```Scala
`65`		`-libraryDependencies+="com.google.cloud"%"google-cloud-redis"%"2.0.5"`
	`65`	`+libraryDependencies+="com.google.cloud"%"google-cloud-redis"%"2.0.6"`
`66`	`66`	```
`67`	`67`
`68`	`68`	`##Authentication`

Comments

(0)