NotificationsYou must be signed in to change notification settings
Fork129
Star123

Commit251d468

authored

fix: NPE issue with testMultipleRuns (#2050)

Added a `null` check for `firstPage.getSchema()` as we might get null schema when the job is long running (We get schema using dryRun in such cases)Fixes#2049 ☕️

1 parentbf77967 commit251d468Copy full SHA for 251d468

File tree

1 file changed

-2

lines changed

google-cloud-bigquery/src/main/java/com/google/cloud/bigquery
- ConnectionImpl.java

1 file changed

-2

lines changed

`‎google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionImpl.java‎`

Lines changed: 4 additions & 2 deletions

Original file line number	Diff line number	Diff line change
`@@ -234,8 +234,10 @@ public BigQueryResult executeSelect(`
`234`	`234`	`BigQueryResultgetResultSet(`
`235`	`235`	`GetQueryResultsResponsefirstPage,JobIdjobId,Stringsql,BooleanhasQueryParameters) {`
`236`	`236`	`if (firstPage.getJobComplete()`
`237`		`- &&firstPage.getTotalRows()`
`238`		`- !=null) {// firstPage.getTotalRows() is null if job is not complete`
	`237`	`+ &&firstPage.getTotalRows() !=null`
	`238`	`+ &&firstPage.getSchema()`
	`239`	`+ !=null) {// firstPage.getTotalRows() is null if job is not complete. We need to make`
	`240`	`+// sure that the schema is not null, as it is required for the ResultSet`
`239`	`241`	`returngetSubsequentQueryResultsWithJob(`
`240`	`242`	`firstPage.getTotalRows().longValue(),`
`241`	`243`	`(long)firstPage.getRows().size(),`

0 commit comments

Comments

(0)

Movatterモバイル変換

Navigation Menu

Search code, repositories, users, issues, pull requests...

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Commit251d468

File tree

1 file changed

1 file changed

`‎google-cloud-bigquery/src/main/java/com/google/cloud/bigquery/ConnectionImpl.java‎`

0 commit comments