This repository was archived by the owner on Sep 9, 2023. It is now read-only.
- Notifications
You must be signed in to change notification settings - Fork22
feat(samples): add create-featurestore sample#948
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
snippet-botbot commentedJun 10, 2022 • edited
Loading Uh oh!
There was an error while loading.Please reload this page.
edited
Uh oh!
There was an error while loading.Please reload this page.
Here is the summary of changes. You are about to add 2 region tags.
This comment is generated bysnippet-bot.
|
| int maxNodeCount = 5; | ||
| String location = "us-central1"; | ||
| String endpoint = "us-central1-aiplatform.googleapis.com:443"; | ||
| int timeout = 900; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Pls change this 15 minutes
ContributorAuthor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
The timeout unit is kept in seconds so I have given 900 which is equal to 15 minutes, Should I change the timeout unit to minutes??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Ah, sorry my math. lgtm
diemtvu commentedJun 14, 2022
Please move new changes to a new PR. Let's keep this PR small so to make sure all reviews are done properly. Thanks |
Latest Code Merge
diemtvu previously approved these changesJun 16, 2022
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here:https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here:https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
diemtvu approved these changesJun 21, 2022
Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here:https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot. |
dizcology approved these changesJun 21, 2022
gcf-merge-on-greenbot pushed a commit that referenced this pull requestJul 1, 2022
🤖 I have created a release *beep* *boop*---## [3.0.0](v2.9.8...v3.0.0) (2022-07-01)### ⚠ BREAKING CHANGES* added packaging options for C#, Ruby, and PHP### Features* add BatchImportModelEvaluationSlices API in aiplatform v1 model_service.proto ([#972](#972)) ([3041b97](3041b97))* add BatchImportModelEvaluationSlices API in aiplatform v1beta1 model_service.proto ([3041b97](3041b97))* add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([0ae5d15](0ae5d15))* add ListSavedQueries rpc to aiplatform v1 dataset_service.proto ([#975](#975)) ([85be17b](85be17b))* add ListSavedQueries rpc to aiplatform v1beta1 dataset_service.proto ([85be17b](85be17b))* add model_monitoring_config to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([#892](#892)) ([0ae5d15](0ae5d15))* add model_version_id to BatchPredictionJob in aiplatform v1 batch_prediction_job.proto ([3041b97](3041b97))* add model_version_id to DeployedModel in aiplatform v1 endpoint.proto ([3041b97](3041b97))* add model_version_id to PredictResponse in aiplatform v1 prediction_service.proto ([3041b97](3041b97))* add saved_query_id to InputDataConfig in aiplatform v1 training_pipeline.proto ([85be17b](85be17b))* add saved_query_id to InputDataConfig in aiplatform v1beta1 training_pipeline.proto ([85be17b](85be17b))* add saved_query.proto to aiplatform v1 ([85be17b](85be17b))* add saved_query.proto to aiplatform v1beta1 ([85be17b](85be17b))* add template_metadata to PipelineJob in aiplatform v1beta1 pipeline_job.proto ([0ae5d15](0ae5d15))* **samples:** add create-featurestore sample ([#948](#948)) ([ac7ca36](ac7ca36))### Bug Fixes* added packaging options for C#, Ruby, and PHP ([0ae5d15](0ae5d15))* update gapic-generator-java with mock service generation fixes ([#979](#979)) ([745b9cd](745b9cd))### Dependencies* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([#973](#973)) ([87b311d](87b311d))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
github-actionsbot pushed a commit to suztomo/google-cloud-java that referenced this pull requestJul 1, 2022
🤖 I have created a release *beep* *boop*---## [3.0.0](googleapis/java-aiplatform@v2.9.8...v3.0.0) (2022-07-01)### ⚠ BREAKING CHANGES* added packaging options for C#, Ruby, and PHP### Features* add BatchImportModelEvaluationSlices API in aiplatform v1 model_service.proto ([googleapis#972](googleapis/java-aiplatform#972)) ([7f45b24](googleapis/java-aiplatform@7f45b24))* add BatchImportModelEvaluationSlices API in aiplatform v1beta1 model_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))* add display_name and metadata to ModelEvaluation in aiplatform model_evaluation.proto ([a2a404f](googleapis/java-aiplatform@a2a404f))* add ListSavedQueries rpc to aiplatform v1 dataset_service.proto ([googleapis#975](googleapis/java-aiplatform#975)) ([ab9ba69](googleapis/java-aiplatform@ab9ba69))* add ListSavedQueries rpc to aiplatform v1beta1 dataset_service.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69))* add model_monitoring_config to BatchPredictionJob in aiplatform v1beta1 batch_prediction_job.proto ([googleapis#892](googleapis/java-aiplatform#892)) ([a2a404f](googleapis/java-aiplatform@a2a404f))* add model_version_id to BatchPredictionJob in aiplatform v1 batch_prediction_job.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))* add model_version_id to DeployedModel in aiplatform v1 endpoint.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))* add model_version_id to PredictResponse in aiplatform v1 prediction_service.proto ([7f45b24](googleapis/java-aiplatform@7f45b24))* add saved_query_id to InputDataConfig in aiplatform v1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69))* add saved_query_id to InputDataConfig in aiplatform v1beta1 training_pipeline.proto ([ab9ba69](googleapis/java-aiplatform@ab9ba69))* add saved_query.proto to aiplatform v1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69))* add saved_query.proto to aiplatform v1beta1 ([ab9ba69](googleapis/java-aiplatform@ab9ba69))* add template_metadata to PipelineJob in aiplatform v1beta1 pipeline_job.proto ([a2a404f](googleapis/java-aiplatform@a2a404f))* **samples:** add create-featurestore sample ([googleapis#948](googleapis/java-aiplatform#948)) ([ffc4b87](googleapis/java-aiplatform@ffc4b87))### Bug Fixes* added packaging options for C#, Ruby, and PHP ([a2a404f](googleapis/java-aiplatform@a2a404f))* update gapic-generator-java with mock service generation fixes ([googleapis#979](googleapis/java-aiplatform#979)) ([e5f3ca5](googleapis/java-aiplatform@e5f3ca5))### Dependencies* update dependency com.google.cloud:google-cloud-shared-dependencies to v2.13.0 ([googleapis#973](googleapis/java-aiplatform#973)) ([56ad705](googleapis/java-aiplatform@56ad705))---This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for freeto subscribe to this conversation on GitHub. Already have an account?Sign in.
Labels
api: vertex-aiIssues related to the googleapis/java-aiplatform API. samplesIssues that are directly related to samples. size: lPull request size is large.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
#945