chore: add suppress warning for TrustAllX509TrustManager since that is what the method is actually supposed to do#2091

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Jump to bottom

Open

ldetmer wants to merge1 commit intomain

base:main

Choose a base branch

fromsuppress-TrustAllX509TrustManager

Open

chore: add suppress warning for TrustAllX509TrustManager since that is what the method is actually supposed to do#2091

ldetmer wants to merge1 commit intomainfromsuppress-TrustAllX509TrustManager

Conversation

Copy link

Contributor

ldetmer commentedMar 28, 2025

This was flagged by android team as an issue when they take in our SDK

Fixes #1866

chore: add suppress warning for TrustAllX509TrustManager since that i…

538ebe3

…s what the method is actually supposed to do

ldetmer requested a review froma team as acode owner

March 28, 2025 12:40

product-auto-labelbot added the size: xsPull request size is extra small. label

Mar 28, 2025

ldetmer requested a review fromdiegomarquezp

March 28, 2025 12:40

Copy link

paulthomson commentedMar 28, 2025

Note that@SuppressWarnings only has source retention, so it will not make it to the bytecode jar library, and so Android Lint will still potentially report a warning for any developers that use this library in their Android app.

For this reason, Android Lint only looks for@SuppressLint in the bytecode. It can come from any package, so you may want to just create your own SuppressLint annotation (see internal bug for example).