- Notifications
You must be signed in to change notification settings - Fork466
feat: support JDK 23#2064
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Merged
feat: support JDK 23#2064
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
ldetmer approved these changesJan 28, 2025
b6a3616 intomain 17 of 19 checks passed
Uh oh!
There was an error while loading.Please reload this page.
svc-squareup-copybara pushed a commit to cashapp/misk that referenced this pull requestFeb 7, 2025
| Package | Type | Package file | Manager | Update | Change ||---|---|---|---|---|---||[com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore)| dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.26.0` -> `2.26.1` ||[com.google.http-client:google-http-client-jackson2](https://github.com/googleapis/google-http-java-client)| dependencies | misk/gradle/libs.versions.toml | gradle | minor |`1.45.3` -> `1.46.0` ||[com.google.http-client:google-http-client](https://github.com/googleapis/google-http-java-client)| dependencies | misk/gradle/libs.versions.toml | gradle | minor |`1.45.3` -> `1.46.0` || [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.30.14` -> `2.30.15` ||[software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava)| dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.30.14` -> `2.30.15` || [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.30.14` -> `2.30.15` || [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.30.14` -> `2.30.15` || [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.30.14` -> `2.30.15` || [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) |dependencies | misk/gradle/libs.versions.toml | gradle | patch |`2.30.14` -> `2.30.15` |---### Release Notes<details><summary>googleapis/java-datastore(com.google.cloud:google-cloud-datastore)</summary>###[`v2.26.1`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2261-2025-02-05)##### Bug Fixes- **deps:** Update the Java code generator (gapic-generator-java) to2.52.0([9594024](googleapis/java-datastore@9594024))##### Dependencies- Update dependency com.google.cloud:gapic-libraries-bom to v1.51.0([#​1726](googleapis/java-datastore#1726))([89f31a8](googleapis/java-datastore@89f31a8))</details><details><summary>googleapis/google-http-java-client(com.google.http-client:google-http-client-jackson2)</summary>###[`v1.46.0`](https://github.com/googleapis/google-http-java-client/blob/HEAD/CHANGELOG.md#1460-2025-02-06)##### Features- Support JDK 23([#​2064](googleapis/google-http-java-client#2064))([b6a3616](googleapis/google-http-java-client@b6a3616))- Update and adapt to GraalVM for JDK 23([#​2069](googleapis/google-http-java-client#2069))([7a0fab3](googleapis/google-http-java-client@7a0fab3))##### Dependencies- Update actions/upload-artifact action to v4.6.0([#​2056](googleapis/google-http-java-client#2056))([1e70d04](googleapis/google-http-java-client@1e70d04))- Update dependency io.grpc:grpc-context to v1.70.0([#​2068](googleapis/google-http-java-client#2068))([7a580bf](googleapis/google-http-java-client@7a580bf))- Update project.appengine.version to v2.0.32([#​2065](googleapis/google-http-java-client#2065))([2285bb1](googleapis/google-http-java-client@2285bb1))</details>---### Configuration📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2amevery weekday" in timezone Australia/Melbourne, Automerge - At any time(no schedule defined).🚦 **Automerge**: Disabled by config. Please merge this manually once youare satisfied.♻ **Rebasing**: Never, or you tick the rebase/retry checkbox.👻 **Immortal**: This PR will be recreated if closed unmerged. Get[config help](https://github.com/renovatebot/renovate/discussions) ifthat's undesired.---- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, checkthis box---This PR has been generated by [RenovateBot](https://github.com/renovatebot/renovate).GitOrigin-RevId: 9507906cb3cb7366a85164991512d76c540932bf
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#2063
Thanks to@ldetmer and@burkedavison for the pointers on how to solve this.
The approach is to
flush()a first byte in the test pointed out by the issue. That triggers sending the headers and unblocksNetHttpResponse.<init>