- Notifications
You must be signed in to change notification settings - Fork1.6k
feat(bigquery): add timeout parameter to QueryJob.done() method#9875
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
Merged
Uh oh!
There was an error while loading.Please reload this page.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.Learn more about bidirectional Unicode characters
Uh oh!
There was an error while loading.Please reload this page.
Uh oh!
There was an error while loading.Please reload this page.
This was referencedDec 4, 2019
ContributorAuthor
plamut commentedDec 9, 2019
87d74f7 to2044a84CompareContributorAuthor
plamut commentedDec 11, 2019
A snippets test failed, seems like flakiness (it passed on several previous runs). Re-running. |
This was referencedDec 11, 2019
In addition, fix the timeout logic in QueryJob.done() - the timeoutsare in different units (seconds vs. milliseconds)
The new timeout feature requires more recent versions of the API coreand google auth dependencies.
tswast requested changesDec 18, 2019
Uh oh!
There was an error while loading.Please reload this page.
If the server-side processing timeout is used (the `timeout_ms` APIparameter) as the total timeout, it should be slightly longer thanthe actual server-side timeout in order to not timeout the connectionwhile there might still be chance that the server-side processinghas actually completed.
tswast approved these changesDec 19, 2019
Contributor
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Thanks!
This was referencedJan 29, 2020
Closed
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment
Labels
api: bigqueryIssues related to the BigQuery API. cla: yesThis human has signed the Contributor License Agreement. type: feature request‘Nice-to-have’ improvement, new feature or different behavior or design.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading.Please reload this page.
Fixes#7831.
Requires#9873.
This is a proposed fix for the
done()method getting stuck. It makes sure that the underlying HTTP request does not block indefinitely when retrieving query results, and that any underlyingrequestsexceptions are retriable.TODO
timeoutparameter to_http.JSONConnection.api_request()(feat(core): add timeout param to JSONConnection.api_request() #9915)timeoutparameter togoogle.auth.transport.AuthorizedSession.request()that BigQuery client uses as its transport (feat: add timeout parameter to AuthorizedSession.request() google-auth-library-python#406)setup.pyto depend on the newapi_coreversion, and the newauthlibrary version (once the timeout-related changes are merged, and the new versions of those libraries released).