Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

fix(bigquery): preserve job config passed to Client methods#9735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
tswast merged 1 commit intogoogleapis:masterfromplamut:iss-9727
Nov 12, 2019

Conversation

@plamut
Copy link
Contributor

@plamutplamut commentedNov 12, 2019•
edited
Loading

Fixes#9727.

This PR fixes the client methods possibly modifying JobConfig instances passed to them.

How to test

Run the example from the ticket description in a debugger, and verify that thejob_config instance is indeed not modified when passing it toclient.query(). Ditto for any other public client methods that accepts job config as an argument, including the Client class initializer.

PR checklist

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

This commit assures that Client's methods that accept job config asan argument operate on deep copies, and do not modify the originaljob config instances passed to them.
@plamutplamut added type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns. api: bigqueryIssues related to the BigQuery API. labelsNov 12, 2019
@plamutplamut requested a review froma teamNovember 12, 2019 13:12
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelNov 12, 2019
@plamutplamut removed the type: bugError or flaw in code with unintended results or allowing sub-optimal usage patterns. labelNov 12, 2019
Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

@tswasttswasttswast approved these changes

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: Client.query modifies job_config object

3 participants

@plamut@tswast@googlebot
[8]ページ先頭
©2009-2025 Movatter.jp