Movatterモバイル変換

[0]ホーム
URL:

Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

 Sign up
Appearance settings

feat(bigquery): add--destination_table parameter to bigquery magic#9599

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.

Already on GitHub?Sign in to your account

Merged
plamut merged 1 commit intogoogleapis:masterfromvlasenkoalexey:master
Nov 6, 2019

Conversation

@vlasenkoalexey
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as abug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Sample use and test here:https://colab.research.google.com/drive/1vd_5IperzwBdqnzIPKd8fWkGZg4TO1Bb (google access only)

Fixes#9598
@sshrdp FYI

tswast reacted with hooray emoji
@vlasenkoalexeyvlasenkoalexey requested a review froma teamNovember 5, 2019 01:37
@googlebotgooglebot added the cla: yesThis human has signed the Contributor License Agreement. labelNov 5, 2019
@vlasenkoalexey
Copy link
ContributorAuthor

@tswast could you take a look

Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

This looks good and seems to work as expected. 👍

I only have a few minor house-keeping comments.

@tseavertseaver changed the titleadded --destination_table parameter to bigquery magicfeat(bigquery): add--destination_table parameter to bigquery magicNov 5, 2019
Copy link
ContributorAuthor

@vlasenkoalexeyvlasenkoalexey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Updated PR

@plamutplamut added the api: bigqueryIssues related to the BigQuery API. labelNov 5, 2019
Copy link
Contributor

@plamutplamut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others.Learn more.

Looks good now, thanks!

@vlasenkoalexey
Copy link
ContributorAuthor

Is Kokoro - Cloud Build failure a real issue or just a glitch? It doesn't return any logs.

@tswast
Copy link
Contributor

Cloud Build client is currently broken, so this failure is expected.

@plamut
Copy link
Contributor

As@tswast said - the Cloud Build is currently broken, and the failure is unrelated to this PR.

Sign up for freeto join this conversation on GitHub. Already have an account?Sign in to comment

Reviewers

1 more reviewer

@plamutplamutplamut approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: bigqueryIssues related to the BigQuery API.cla: yesThis human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BigQuery: Add destination_table to %%bigquery magic to allow materializing query results

4 participants

@vlasenkoalexey@tswast@plamut@googlebot
[8]ページ先頭
©2009-2025 Movatter.jp