- Notifications
You must be signed in to change notification settings - Fork1.6k
feat(storage): add opt-in raw download support#9572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to ourterms of service andprivacy statement. We’ll occasionally send you account related emails.
Already on GitHub?Sign in to your account
feat(storage): add opt-in raw download support#9572
Uh oh!
There was an error while loading.Please reload this page.
Conversation
Avoid depending on implementation details of download objects fromgoogle-resumable-media.
Avoid depending on implementation details of download objects fromgoogle-resumable-media.
Never import module-under-test at module scope of testcase.
Avoid reusing fixtures which do more than needed.
Consolidate duplicated code in prep for adding 'raw_download' option.
If True, uses the 'RawDownload' / 'RawChunkedDownload' helpers from'google.resumable_media', ensuring that the contents are not expandedby the requests transport.
If True, uses the 'RawDownload' / 'RawChunkedDownload' helpers from'google.resumable_media', ensuring that the contents are not expandedby the requests transport.
tswast left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM for BigQuery change
frankyn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
Will review and marking as requested changes to prevent merges.
Thank you for your patience.
frankyn left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others.Learn more.
LGTM, thanks for patience@tseaver.
Note to reviewers: this is likely better viewed commit-by-commit.
Bumps
google-resumable-mediadependency forgoogle-cloud-storageto require >= 0.5.0, whilegoogle-cloud-bigqueryjust allows it (BigQuery doesn't use the download classes).Closes#9565.